Uh oh!
There was an error while loading. Please reload this page.
Add documentation for BatchClient, BatchResult and BatchException - #20
Conversation
joelwurtz
commented
Oct 31, 2015
Awesome <3 ! 👍 |
There was a problem hiding this comment.
Does the exception check make sense here? Exception is thrown if any.
sagikazarmark
commented
Oct 31, 2015
Added one comment. Please squash commits. Thanks @thormeier |
884c455 to
35bff47Comparethormeier
commented
Oct 31, 2015
Fixed mentioned things and squashed commits. |
sagikazarmark
commented
Oct 31, 2015
Thanks @thormeier |
Add documentation for BatchClient, BatchResult and BatchException
There was a problem hiding this comment.
this is assuming that the post request did not fail and would throw an exception if it failed. in this flow of code, that can't happen as we would have bailed out with an exception. but that means $fooSuccessful is pointless. i would move the isSuccessful check below to the error handling logic, as its only relevant in the error case to figure out if something went wrong or not.
There was a problem hiding this comment.
Wow, my breain blown up while following this reasoning (guess it's sunday evening), so I just agree with you. 😉
There was a problem hiding this comment.
yeah, sunday evening here as well :-D i think in the middle i realized that we can just expect the response to be there in this case... but we should separate the examples to make it more clear. we could even mention that we can just assume responses are here as otherwise there would be the exception thrown.
dbu
commented
Nov 1, 2015
thanks a lot for the contribution! i commented some details, if you find some time to clean this up, great, but at least we have some documentation now. |
Solves #16