Uh oh!
There was an error while loading. Please reload this page.
chore: add testrun for "psr/http-message" v2 - #159
Conversation
Chris53897
commented
Jan 23, 2024
I do not know how to fix the changes between slim 3 and 4. |
dbu
commented
Jan 23, 2024
i am a bit afraid of testing with a dev version. could we just remove slim from require-dev and add it with composer commands in the github ci for some builds but not all? and have the tests that depend on slim skip if slim is not available? |
Chris53897
commented
Jan 23, 2024
Yes of course. Maybe they will release a new version? But i would suggest that the breaking-changes should be fixed first. |
dbu
commented
Mar 16, 2024
slim has tagged a release. can you please rebase this branch onto 1.x and push again? then we can see what problems remain. |
9bedc3f to
764a2c6CompareChris53897
commented
Mar 16, 2024
@dbu Thanks |
dbu
left a comment
There was a problem hiding this comment.
@Chris53897 do you have updates on this one? anything blocking, or did you just not find time to continue?
| run: | | ||
| rm src/MessageFactory/SlimMessageFactory.php src/StreamFactory/SlimStreamFactory.php src/UriFactory/SlimUriFactory.php spec/MessageFactory/SlimMessageFactorySpec.php spec/StreamFactory/SlimStreamFactorySpec.php spec/UriFactory/SlimUriFactorySpec.php | ||
| composer remove --dev "slim/slim" --no-interaction --no-update | ||
| composer require "psr/http-message:^2.0" --no-interaction --no-update |
There was a problem hiding this comment.
should we not keep this test around?
see #158
Just for testing the CI