Skip to content

Fix BC break - #33

Merged
sagikazarmark merged 5 commits into
php-http:masterfrom
nenad:minor/fix-bc-break
Nov 3, 2018
Merged

Fix BC break#33
sagikazarmark merged 5 commits into
php-http:masterfrom
nenad:minor/fix-bc-break

Conversation

@nenad

@nenadnenad commented May 1, 2018

Copy link
Copy Markdown
Contributor
QA
Bug fix?no
New feature?no
BC breaks?yes
Deprecations?no
Related ticketsfixes#32
Documentation
LicenseMIT

What's in this PR?

Adds a workaround for missing LoopInterface::tick() method.

Why?

Since react/http-client utilizes newer versions of react/event-loop which have BC in them, the tick() method no longer exists. This PR adds a workaround to fix that.

Example Usage

Checklist

  • Updated CHANGELOG.md to describe BC breaks (composer.json requirements)

@nenad
nenadforce-pushed the minor/fix-bc-break branch from f4cc094 to 21a0646CompareMay 1, 2018 21:11
@fbourigault

Copy link
Copy Markdown

Hello @nenadstojanovikj do you have time to look at the travis-ci build failures ?

As we are using some methods from LoopInterface, can you add an explicit dependency on react/event-loop with the ^0.5 || ^1.0 constraint ?

@nenad

Copy link
Copy Markdown
ContributorAuthor

I updated some more deps since build was still failing because of react/event-loop calling functions that didn't exist inreact/stream. I also moved some of the deps to ^1.0 since they are following semantic versioning.

@nenad

Copy link
Copy Markdown
ContributorAuthor

@joelwurtz Could this be merged?

@sagikazarmark

Copy link
Copy Markdown
Member

@nenadstojanovikj Thanks a lot for this fix!

@sagikazarmark
sagikazarmark merged commit e38f00c into php-http:masterNov 3, 2018
@nenad
nenad deleted the minor/fix-bc-break branch July 29, 2019 15:44
@dbudbu mentioned this pull request Jul 30, 2019
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for react/http-client > 0.5.0

4 participants

@nenad@fbourigault@sagikazarmark@joelwurtz