Skip to content

Stop support for PHP 5.5 - #37

Merged
dbu merged 2 commits into
php-http:masterfrom
nenad:patch/stop-support-5-5
Jul 30, 2019
Merged

Stop support for PHP 5.5#37
dbu merged 2 commits into
php-http:masterfrom
nenad:patch/stop-support-5-5

Conversation

@nenad

Copy link
Copy Markdown
Contributor
QA
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Related ticketsno
Documentationno
LicenseMIT

What's in this PR?

Stop support for PHP 5.5

Why?

Prevents us from migrating to newer version of react components.

@nenadnenad mentioned this pull request Jul 29, 2019
3 tasks
dbu
dbu approved these changes Jul 30, 2019

@dbudbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should bump all the way to PHP 7.1 while we are at it. and increase the minor version in the composer branch-alias so we will be 2.2. i guess in this case its very unlikely to matter, but just out of principle so that we can release security fixes that people stuck on legacy php versions.

@xabbuhxabbuh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we need to update the PHP version for the job that runs with lowest dependencies too.

@nenad
nenadforce-pushed the patch/stop-support-5-5 branch from 4c8e008 to dbd3f10CompareJuly 30, 2019 08:43
@nenad

Copy link
Copy Markdown
ContributorAuthor

In fact, we need to update the PHP version for the job that runs with lowest dependencies too.

I removed PHP 5.5 from the Travis build completely. Does this comment refer to adding the lowest dependencies job to PHP 7.1 or some other version?

Comment thread.travis.yml
@dbu
dbu merged commit 5d75e5b into php-http:masterJul 30, 2019
@nenad
nenad deleted the patch/stop-support-5-5 branch July 30, 2019 09:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nenad@dbu@xabbuh