Uh oh!
There was an error while loading. Please reload this page.
Make package compatible with stream interface Compatibility stream interface v2 - #75
Conversation
TO BE REVERTED after [1] AND need to update min version for the tests package [1] php-http/client-integration-tests#60
… current implementation to avoid having failed tests
There is implementation for interface from this package
andrew-demb
commented
Aug 7, 2024
/cc @dbu |
Uh oh!
There was an error while loading. Please reload this page.
andrew-demb
commented
Aug 7, 2024
$ vendor/bin/phpunit
PHPUnit 9.6.20 by Sebastian Bergmann and contributors.
SSSSS............................................................ 65 / 89 ( 73%)
........................ 89 / 89 (100%)
Time: 00:21.389, Memory: 10.00 MB
OK, but incomplete, skipped, or risky tests!
Tests: 89, Assertions: 901, Skipped: 5. |
Uh oh!
There was an error while loading. Please reload this page.
dbu
commented
Sep 1, 2024
thanks a lot! ok to make this 2.3 instead of 3.0? and can you see if you can fix the phpstan complaint? looks like we miss some sanity check (or have incorrect annotations somewhere) |
andrew-demb
commented
Sep 1, 2024
I'm Ok with documenting minor BC break for extenders of the |
…ring in case of `0` length
andrew-demb
commented
Sep 1, 2024
Done. |
dbu
left a comment
There was a problem hiding this comment.
thanks for your contribution!
i will adjust the changelog and add the @internal after merging.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
\Http\Client\Socket\Streamclass)What's in this PR?
Replaces #72
Fixes compatibility with
psr/http-messagev2Why?
For now, the current package contains implementation for the
\Psr\Http\Message\StreamInterface, but there's no mention of supported versions ofpsr/http-messagein composer.json.After some upgrades of
php-http/httpplug- they declared compatibility withpsr/http-messagev2 and the current package was broken if the project installed it withpsr/http-messagev2 (see mentioned issue)Checklist