Uh oh!
There was an error while loading. Please reload this page.
Handle Datetime serialization - #148
Merged
Merged
Conversation
tchiotludo
commented
Feb 14, 2018
ContributorAuthor
Any update ? |
haphan
requested changes
Feb 16, 2018
Collaborator
There was a problem hiding this comment.
LGTM. Please also re-base with master. Thank you
@tchiotludo
| if ($val instanceof Serializable) { | ||
| return $val->serialize(); | ||
| } else if ($val instanceof \DateTimeImmutable) { | ||
| return $val->format('Y-m-d H:i:s.u'); |
Collaborator
There was a problem hiding this comment.
use ISO 8601 instead of hard-code date time format $val->format('c')
tchiotludo
commented
Feb 16, 2018
ContributorAuthor
done & thanks 👍 |
haphan
commented
Feb 16, 2018
Collaborator
Please fix travis error (PSR2) @tchiotludo then we are good to go. |
haphan
approved these changes
Feb 16, 2018
haphan
commented
Feb 16, 2018
Collaborator
thanks @tchiotludo |
tchiotludo
commented
Feb 16, 2018
ContributorAuthor
np @haphan, good to see my fork disappear 😄 |
haphan
commented
Feb 16, 2018
Collaborator
@tchiotludo As we are trying to maintain branch 2.x till end of March 2018, can you also back-port this fix to branch 2.0 Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serialize method don't handle correctly
\DateTimeImmutableThe unserialize method expect a string (\DateTimeImmutable constructor)
But the serialize method serialize '\DateTimeImmutable' as object
This throw an
DateTimeImmutable::__construct() expects parameter 1 to be string, object givenon calling->populateFromArray((array) $serialize)