Skip to content

Add Server::resetState method - #196

Merged
haphan merged 2 commits into
php-opencloud:masterfrom
laszlof:add-server-resetstate
Feb 5, 2018
Merged

Add Server::resetState method#196
haphan merged 2 commits into
php-opencloud:masterfrom
laszlof:add-server-resetstate

Conversation

@laszlof

Copy link
Copy Markdown
Contributor

Add functionality to reset the state of a VM.

@haphanhaphan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @laszlof. Only a few minor changes needed.

Comment threadsrc/Compute/v2/Models/Server.php Outdated
*/
public function resetState()
{
$response = $this->execute($this->api->resetServerState(), [

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove $response

Comment threadsrc/Compute/v2/Params.php Outdated
]);
}

public function osResetState(): array

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use resetState

Comment threadsrc/Compute/v2/Api.php Outdated
'path' => 'servers/{id}/action',
'params' => [
'id' => $this->params->urlId('server'),
'resetState' => $this->params->osResetState()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use resetState

@haphan

Copy link
Copy Markdown
Collaborator

@laszlof I left some minor change requests :)

@laszlof

laszlof commented Feb 5, 2018 via email

Copy link
Copy Markdown
ContributorAuthor

@laszlof

Copy link
Copy Markdown
ContributorAuthor

@haphan The issues have been corrected.

@haphan
haphan merged commit 40f7ec9 into php-opencloud:masterFeb 5, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@laszlof@haphan