Fix number of segments of a large object

[mzur]

This fixes an off by one error with the number of segments of large objects uploaded to Swift.

The total number of segments was determined with round($streamSize/$segmentSize). In cases like $streamSize=24 and $segmentSize=10 this resulted in one segment too few that was uploaded. This has been fixed by simply omitting round(). I also updated the test which did not fail before by pure chance.

[coveralls]

Pull Request Test Coverage Report for Build 623

• 4 of 4(100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 96.136%

---

Totals
Change from base Build 621:	0.002%
Covered Lines:	1692
Relevant Lines:	1760

---

💛 - Coveralls

[haphan]

thanks @mzur 🚀

[ErwanGuillon]

When do you think you will tag a version for this? I'm not very confortable by using the dev branch in production and it's a blocker for me as I upload very large files.

Thanks for the hard work.

[dsnopek]

Please tag a new version with this! We got bit by this bug, and 75% of our backups were corrupted. Of course, I tested one of the backups, but it was among the 25% where the last segment was greater than half the segment size so all the segments were uploaded. We lost a whole bunch of data due to this.

Now we're using the latest from Git, but I'm sure this bug will cause more people to have data loss issues!

[haphan]

@dsnopek Thanks for bringing my attention to this issue. I’ve released 3.0.6 to address this.

My intention was to backport this fix to 2.x branch as well before tagging.

[ErwanGuillon]

Thanks @haphan