Uh oh!
There was an error while loading. Please reload this page.
Fix testing class namespaces - #317
Closed
peter279k wants to merge 1 commit into
Closed
Conversation
peter279k
commented
Nov 4, 2020
| use function GuzzleHttp\Psr7\parse_response; | ||
| use GuzzleHttp\ClientInterface; | ||
| use GuzzleHttp\Psr7\Response; | ||
| use Prophecy\Argument; |
ContributorAuthor
There was a problem hiding this comment.
It's declared, but not used. It should be removed.
haphan
commented
Nov 5, 2020
Collaborator
@peter279k thanks for this pr. Does it break anything or more of inconsistency issue? |
peter279k
commented
Nov 5, 2020
ContributorAuthor
This will not break anything and it's only for testing when PHPUnit does unit tests and load namespaces autoloading. |
haphan
commented
Nov 5, 2020
Collaborator
I mean before this fix, what was not working? |
peter279k
commented
Nov 5, 2020
ContributorAuthor
When using the refactor, it will present some test classes are not found. And I fix them to be compatible with PSR-4 autoloader. |
haphan
commented
Nov 5, 2020
Collaborator
Let me do a quick review later this week |
k0ka
commented
Jan 7, 2024
Member
After 3 years of quick review we were able to merge it =). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed log
PSR-4autoloader.