Uh oh!
There was an error while loading. Please reload this page.
Server groups - #435
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Compute v2 “Server Groups” support to the SDK, addressing issue #434 by introducing a ServerGroup model plus the corresponding API/service surface, tests, samples, and docs.
Changes:
- Added
ServerGroupmodel with list/retrieve/create/delete support and response-shape compatibility forpolicyvspolicies. - Exposed server-group operations in
Compute\v2\Api+Compute\v2\Service, including query params likeall_projects,limit, andoffset. - Added unit tests, sample tests, runnable samples, and Sphinx docs for server groups.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Compute/v2/Api.php | Adds REST operation definitions for server-group CRUD/list. |
src/Compute/v2/Models/ServerGroup.php | Implements the ServerGroup resource behavior and hydration rules. |
src/Compute/v2/Params.php | Adds parameter schemas for server-group list/create options (incl. rules). |
src/Compute/v2/Service.php | Adds top-level service methods: list/create/get server groups. |
tests/unit/Compute/v2/ServiceTest.php | Adds service-level tests for server-group create/list/get. |
tests/unit/Compute/v2/Models/ServerGroupTest.php | Adds model-level tests for server-group retrieve/create/delete and option validation. |
tests/unit/Compute/v2/Fixtures/*.resp | Adds mocked HTTP fixtures for server-group list/get/post. |
samples/Compute/v2/server_groups/*.php | Adds user-facing sample scripts for server-group workflows. |
tests/sample/Compute/v2/ServerGroupTest.php | Adds integration-style sample test coverage for server groups. |
doc/services/compute/v2/server-groups.rst | Adds end-user documentation for server groups, including microversion guidance. |
doc/services/compute/v2/index.rst | Links the new server-groups doc page into the Compute v2 docs index. |
AGENTS.md | Documents repository architecture, conventions, and compatibility/testing expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
fixes#434