Only checks for `[skip-revcheck]` at start of commit messages by alfsb · Pull Request #181 · php/doc-base

alfsb · 2024-11-18T12:59:52Z

This PR changes the [skip-revcheck] function. Instead of being activated from anywhere, it only be effective if positioned at the beginning of the commit message, and ignored otherwise.

This is the root cause of #133 .

This PR resolves the issue above (and avoid future cases) by changing the meaning of some commits that have [skip-revcheck] outside of begging of commit messages. They are:

git show --no-patch 3e871fe7eab38f9b0398569c57a1dd0c21e69652 # accidental
git show --no-patch 26e26a95fdc3aac9b464068953ea3105dee00f14 # accidental
git show --no-patch 8f6fd5c55ab10709a4ff8daf6140dea422c1363c # accidental
git show --no-patch f80105b4fc1196bd8d5fecb98d686b580b1ff65d # accidental
git show --no-patch 9d6701a7205c16fc24062e90e2508bb498fbdac5 # accidental
git show --no-patch 38ce6211e1da2f62833f8961511f3c980ea9093b # intended
git show --no-patch 1bfd6a1d79b134d49bf17a1880b719e0efd04198 # intended
git show --no-patch 8afaddf6cc8a90ccba001a52349cb751fcfeb558 # intended

The oldest commits shows that [skip-revcheck] function is originally intended to be used from anywhere in the commit message. But most occurrences are now of accidental usage. Not only are most accidental, but all accidental occurrences are recent ones. This shows that [skip-revcheck] usage shifted from being used anywhere on commit messages.

This PR does not changes the interpretation of other 142[skip-revcheck] usages, all of them occurring at the start of commit messages.

The old most accidental hashes are good examples of what I'm calling accidental usage. f80105 is a squashed commit, and 9d6701 is a reversion one. In both cases, these "grouping" commits includes the one liners of all grouped commits, and if one of individual commit messages contains [skip-revcheck], so this is the case with the grouped commit message.

This will change files from "ok" to "old" in almost all translations. As for now, the changes are:

before	ok	old after	ok	old	diff
de	3148	32 de	3148	32	0
es	3365	3746 es	3359	3752	6
fr	10998	33 fr	10959	72	39
it	172	244 it	171	245	1
ja	7385	236 ja	7373	248	12
pl	1007	42 pl	1006	43	1
pt_BR	8142	1 pt_BR	8142	1	0
ro	161	167 ro	160	168	1
ru	11010	27 ru	10984	53	26
tr	3235	216 tr	3230	221	5
uk	337	79 uk	336	80	1
zh	3092	125 zh	3085	132	7

That is, about a hundred in total.

The Files Changed listing is a bit longer than needed, but this is because this PR depends on #180 . After it is merged, the changed set will shrink to the erasing of backport.php, removing the function parseInto of GitLogParser and:

@@ -142,19 +73,11 @@ class GitLogParser
while ( $proc->live && str_starts_with( $proc->line , ' ' ) )
{
- if ( LOOSE_SKIP_REVCHECK ) // https://github.com/php/doc-base/pull/132- {- // Messages that contains [skip-revcheck] flags entire commit as ignored.- if ( str_contains( $proc->line , '[skip-revcheck]' ) )- $skip = true;- }- else- {- // Messages that start with [skip-revcheck] flags entire commit as ignored.- $lcnt++;- if ( $lcnt == 1 && str_starts_with( trim( $line ) , '[skip-revcheck]' ) )- $skip = true;- }+ // Messages that start with [skip-revcheck] flags entire commit as ignored.+ $lcnt++;+ if ( $lcnt == 1 && str_starts_with( trim( $proc->line ) , '[skip-revcheck]' ) )+ $skip = true;+
$proc->next();
}

Reviews and comments welcome. I also plan to write about usage of [skip-revcheck] somewhere on https://github.com/php/doc-base/tree/master/docs . Suggestions of where?

Draft state, waiting for #180 .

alfsb · 2024-11-25T14:11:38Z

The merge mixed ans trashed the change set. Back to draft while a fix this.

alfsb · 2024-11-25T15:37:42Z

Sorry for noise. Rebased and retested. As detailed above, this fix the root cause of issue 133. Yet, this is breaking change, that impacts all translations. Listed below all files that will tracked as Old with this PR.

Some or most of files may need only revtag changes. Others are real outdated files that remained untracked for almost a year. 98 files total, across all translations.

This said, I do not plan to merge this, as I believe this is an editor level decision.

< es language/predefined/interfaces.xml TranslatedOk
> es language/predefined/interfaces.xml TranslatedOld
< es reference/cubrid/cubridmysql/cubrid-real-escape-string.xml TranslatedOk
> es reference/cubrid/cubridmysql/cubrid-real-escape-string.xml TranslatedOld
< es reference/eio/functions/eio-chmod.xml TranslatedOk
> es reference/eio/functions/eio-chmod.xml TranslatedOld
< es reference/eio/functions/eio-poll.xml TranslatedOk
> es reference/eio/functions/eio-poll.xml TranslatedOld
< es reference/ev/ev/depth.xml TranslatedOk
> es reference/ev/ev/depth.xml TranslatedOld
< es reference/mongodb/tutorial.xml TranslatedOk
> es reference/mongodb/tutorial.xml TranslatedOld
< fr appendices/filters.xml TranslatedOk
> fr appendices/filters.xml TranslatedOld
< fr language/predefined/interfaces.xml TranslatedOk
> fr language/predefined/interfaces.xml TranslatedOld
< fr reference/cubrid/cubridmysql/cubrid-real-escape-string.xml TranslatedOk
> fr reference/cubrid/cubridmysql/cubrid-real-escape-string.xml TranslatedOld
< fr reference/eio/functions/eio-chmod.xml TranslatedOk
> fr reference/eio/functions/eio-chmod.xml TranslatedOld
< fr reference/eio/functions/eio-poll.xml TranslatedOk
> fr reference/eio/functions/eio-poll.xml TranslatedOld
< fr reference/ev/ev/depth.xml TranslatedOk
> fr reference/ev/ev/depth.xml TranslatedOld
< fr reference/ev/ev/run.xml TranslatedOk
> fr reference/ev/ev/run.xml TranslatedOld
< fr reference/ev/evchild/construct.xml TranslatedOk
> fr reference/ev/evchild/construct.xml TranslatedOld
< fr reference/ev/evloop/run.xml TranslatedOk
> fr reference/ev/evloop/run.xml TranslatedOld
< fr reference/ev/evstat/attr.xml TranslatedOk
> fr reference/ev/evstat/attr.xml TranslatedOld
< fr reference/ev/evstat/createstopped.xml TranslatedOk
> fr reference/ev/evstat/createstopped.xml TranslatedOld
< fr reference/ev/evstat/set.xml TranslatedOk
> fr reference/ev/evstat/set.xml TranslatedOld
< fr reference/ev/evtimer/construct.xml TranslatedOk
< fr reference/ev/evtimer/createstopped.xml TranslatedOk
< fr reference/ev/evtimer/set.xml TranslatedOk
< fr reference/ev/evwatcher/clear.xml TranslatedOk
> fr reference/ev/evtimer/construct.xml TranslatedOld
> fr reference/ev/evtimer/createstopped.xml TranslatedOld
> fr reference/ev/evtimer/set.xml TranslatedOld
> fr reference/ev/evwatcher/clear.xml TranslatedOld
< fr reference/event/eventbufferevent/construct.xml TranslatedOk
> fr reference/event/eventbufferevent/construct.xml TranslatedOld
< fr reference/event/eventbufferevent/setwatermark.xml TranslatedOk
> fr reference/event/eventbufferevent/setwatermark.xml TranslatedOld
< fr reference/event/eventconfig/setmaxdispatchinterval.xml TranslatedOk
> fr reference/event/eventconfig/setmaxdispatchinterval.xml TranslatedOld
< fr reference/event/eventdnsbase/parseresolvconf.xml TranslatedOk
> fr reference/event/eventdnsbase/parseresolvconf.xml TranslatedOld
< fr reference/event/eventdnsbase/setsearchndots.xml TranslatedOk
> fr reference/event/eventdnsbase/setsearchndots.xml TranslatedOld
< fr reference/filesystem/functions/stat.xml TranslatedOk
> fr reference/filesystem/functions/stat.xml TranslatedOld
< fr reference/imagick/imagickpixel/getcolor.xml TranslatedOk
> fr reference/imagick/imagickpixel/getcolor.xml TranslatedOld
< fr reference/mcrypt/constants.xml TranslatedOk
> fr reference/mcrypt/constants.xml TranslatedOld
< fr reference/mongodb/architecture.xml TranslatedOk
> fr reference/mongodb/architecture.xml TranslatedOld
< fr reference/mongodb/bson.xml TranslatedOk
< fr reference/mongodb/configure.xml TranslatedOk
> fr reference/mongodb/bson.xml TranslatedOld
> fr reference/mongodb/configure.xml TranslatedOld
< fr reference/mongodb/exceptions.xml TranslatedOk
< fr reference/mongodb/ini.xml TranslatedOk
< fr reference/mongodb/mongodb.xml TranslatedOk
< fr reference/mongodb/monitoring.xml TranslatedOk
< fr reference/mongodb/security.xml TranslatedOk
< fr reference/mongodb/setup.xml TranslatedOk
< fr reference/mongodb/tutorial.xml TranslatedOk
> fr reference/mongodb/exceptions.xml TranslatedOld
> fr reference/mongodb/ini.xml TranslatedOld
> fr reference/mongodb/mongodb.xml TranslatedOld
> fr reference/mongodb/monitoring.xml TranslatedOld
> fr reference/mongodb/security.xml TranslatedOld
> fr reference/mongodb/setup.xml TranslatedOld
> fr reference/mongodb/tutorial.xml TranslatedOld
< fr reference/mongodb/tutorial/apm.xml TranslatedOk
< fr reference/mongodb/tutorial/library.xml TranslatedOk
> fr reference/mongodb/tutorial/apm.xml TranslatedOld
> fr reference/mongodb/tutorial/library.xml TranslatedOld
< fr reference/oci8/functions/oci-set-prefetch.xml TranslatedOk
> fr reference/oci8/functions/oci-set-prefetch.xml TranslatedOld
< fr reference/sockets/functions/socket-read.xml TranslatedOk
> fr reference/sockets/functions/socket-read.xml TranslatedOld
< fr reference/stream/streamwrapper/url-stat.xml TranslatedOk
> fr reference/stream/streamwrapper/url-stat.xml TranslatedOld
< it language/predefined/interfaces.xml TranslatedOk
> it language/predefined/interfaces.xml TranslatedOld
< ja appendices/filters.xml TranslatedOk
> ja appendices/filters.xml TranslatedOld
< ja reference/eio/functions/eio-chmod.xml TranslatedOk
> ja reference/eio/functions/eio-chmod.xml TranslatedOld
< ja reference/eio/functions/eio-poll.xml TranslatedOk
> ja reference/eio/functions/eio-poll.xml TranslatedOld
< ja reference/ev/ev/depth.xml TranslatedOk
> ja reference/ev/ev/depth.xml TranslatedOld
< ja reference/ev/ev/run.xml TranslatedOk
> ja reference/ev/ev/run.xml TranslatedOld
< ja reference/ev/evchild/construct.xml TranslatedOk
> ja reference/ev/evchild/construct.xml TranslatedOld
< ja reference/filesystem/functions/stat.xml TranslatedOk
> ja reference/filesystem/functions/stat.xml TranslatedOld
< ja reference/imagick/imagickpixel/getcolor.xml TranslatedOk
> ja reference/imagick/imagickpixel/getcolor.xml TranslatedOld
< ja reference/mcrypt/constants.xml TranslatedOk
> ja reference/mcrypt/constants.xml TranslatedOld
< ja reference/oci8/functions/oci-set-prefetch.xml TranslatedOk
> ja reference/oci8/functions/oci-set-prefetch.xml TranslatedOld
< ja reference/sockets/functions/socket-read.xml TranslatedOk
> ja reference/sockets/functions/socket-read.xml TranslatedOld
< ja reference/stream/streamwrapper/url-stat.xml TranslatedOk
> ja reference/stream/streamwrapper/url-stat.xml TranslatedOld
< pl language/predefined/interfaces.xml TranslatedOk
> pl language/predefined/interfaces.xml TranslatedOld
< ro reference/mongodb/tutorial.xml TranslatedOk
> ro reference/mongodb/tutorial.xml TranslatedOld
< ru appendices/filters.xml TranslatedOk
> ru appendices/filters.xml TranslatedOld
< ru reference/cubrid/cubridmysql/cubrid-real-escape-string.xml TranslatedOk
> ru reference/cubrid/cubridmysql/cubrid-real-escape-string.xml TranslatedOld
< ru reference/eio/functions/eio-chmod.xml TranslatedOk
> ru reference/eio/functions/eio-chmod.xml TranslatedOld
< ru reference/eio/functions/eio-poll.xml TranslatedOk
> ru reference/eio/functions/eio-poll.xml TranslatedOld
< ru reference/ev/ev/depth.xml TranslatedOk
> ru reference/ev/ev/depth.xml TranslatedOld
< ru reference/ev/ev/run.xml TranslatedOk
> ru reference/ev/ev/run.xml TranslatedOld
< ru reference/ev/evchild/construct.xml TranslatedOk
> ru reference/ev/evchild/construct.xml TranslatedOld
< ru reference/ev/evloop/run.xml TranslatedOk
> ru reference/ev/evloop/run.xml TranslatedOld
< ru reference/ev/evstat/attr.xml TranslatedOk
> ru reference/ev/evstat/attr.xml TranslatedOld
< ru reference/ev/evstat/createstopped.xml TranslatedOk
> ru reference/ev/evstat/createstopped.xml TranslatedOld
< ru reference/ev/evstat/set.xml TranslatedOk
> ru reference/ev/evstat/set.xml TranslatedOld
< ru reference/ev/evtimer/construct.xml TranslatedOk
< ru reference/ev/evtimer/createstopped.xml TranslatedOk
< ru reference/ev/evtimer/set.xml TranslatedOk
< ru reference/ev/evwatcher/clear.xml TranslatedOk
> ru reference/ev/evtimer/construct.xml TranslatedOld
> ru reference/ev/evtimer/createstopped.xml TranslatedOld
> ru reference/ev/evtimer/set.xml TranslatedOld
> ru reference/ev/evwatcher/clear.xml TranslatedOld
< ru reference/event/eventbufferevent/construct.xml TranslatedOk
> ru reference/event/eventbufferevent/construct.xml TranslatedOld
< ru reference/event/eventbufferevent/setwatermark.xml TranslatedOk
> ru reference/event/eventbufferevent/setwatermark.xml TranslatedOld
< ru reference/event/eventconfig/setmaxdispatchinterval.xml TranslatedOk
> ru reference/event/eventconfig/setmaxdispatchinterval.xml TranslatedOld
< ru reference/event/eventdnsbase/parseresolvconf.xml TranslatedOk
> ru reference/event/eventdnsbase/parseresolvconf.xml TranslatedOld
< ru reference/event/eventdnsbase/setsearchndots.xml TranslatedOk
> ru reference/event/eventdnsbase/setsearchndots.xml TranslatedOld
< ru reference/filesystem/functions/stat.xml TranslatedOk
> ru reference/filesystem/functions/stat.xml TranslatedOld
< ru reference/imagick/imagickpixel/getcolor.xml TranslatedOk
> ru reference/imagick/imagickpixel/getcolor.xml TranslatedOld
< ru reference/mcrypt/constants.xml TranslatedOk
> ru reference/mcrypt/constants.xml TranslatedOld
< ru reference/oci8/functions/oci-set-prefetch.xml TranslatedOk
> ru reference/oci8/functions/oci-set-prefetch.xml TranslatedOld
< ru reference/sockets/functions/socket-read.xml TranslatedOk
> ru reference/sockets/functions/socket-read.xml TranslatedOld
< ru reference/stream/streamwrapper/url-stat.xml TranslatedOk
> ru reference/stream/streamwrapper/url-stat.xml TranslatedOld
< tr reference/filesystem/functions/stat.xml TranslatedOk
> tr reference/filesystem/functions/stat.xml TranslatedOld
< tr reference/imagick/imagickpixel/getcolor.xml TranslatedOk
> tr reference/imagick/imagickpixel/getcolor.xml TranslatedOld
< tr reference/mcrypt/constants.xml TranslatedOk
> tr reference/mcrypt/constants.xml TranslatedOld
< tr reference/sockets/functions/socket-read.xml TranslatedOk
> tr reference/sockets/functions/socket-read.xml TranslatedOld
< tr reference/stream/streamwrapper/url-stat.xml TranslatedOk
> tr reference/stream/streamwrapper/url-stat.xml TranslatedOld
< uk appendices/filters.xml TranslatedOk
> uk appendices/filters.xml TranslatedOld
< zh appendices/filters.xml TranslatedOk
> zh appendices/filters.xml TranslatedOld
< zh language/predefined/interfaces.xml TranslatedOk
> zh language/predefined/interfaces.xml TranslatedOld
< zh reference/event/eventconfig/setmaxdispatchinterval.xml TranslatedOk
> zh reference/event/eventconfig/setmaxdispatchinterval.xml TranslatedOld
< zh reference/filesystem/functions/stat.xml TranslatedOk
> zh reference/filesystem/functions/stat.xml TranslatedOld
< zh reference/mcrypt/constants.xml TranslatedOk
> zh reference/mcrypt/constants.xml TranslatedOld
< zh reference/oci8/functions/oci-set-prefetch.xml TranslatedOk
> zh reference/oci8/functions/oci-set-prefetch.xml TranslatedOld
< zh reference/sockets/functions/socket-read.xml TranslatedOk
> zh reference/sockets/functions/socket-read.xml TranslatedOld

Girgias · 2024-12-03T01:32:31Z

For French, I believe @Fan2Shrek and @devnexen should be able to handle it, and I can also chime in.

I know Japanese has a bunch of people now active, pinging @zonuexe, @KentarouTakeda, and @mumumu so they are aware.

Russian is quite active with @saundefined and @mmalferov so I don't expect it to be a problem.

ZH is usually not too behind, and it doesn't seem that problematic, but still going to ping @sy-records

The file affected in PL and IT seems like even I could handle it

RO is basically dead, ES is in a bad state but maybe has a bit of activity? I might go back and do some updates to it, as it is mostly just tedious markup changes that are outdated.

It seems like TR is not affected too badly, so hopefully @nilgun is not too annoyed at them, and if it's only markup changes I'll see if I can do them.

alfsb · 2024-12-03T11:09:45Z

The file affected in PL and IT seems like even I could handle it
[...]
I might go back and do some updates to it, as it is mostly just tedious markup changes that are outdated.

I do not expect breakages in manual builds (as this does not change configure.php). It is a breaking change in the sense that this changesrevcheck.php results, that are used for all translations. Some (most?) of all files listed above may have insignificant changes, but are included because the real problem (unmarked outdated files) got mixed with another revcheck.php issue (already fixed).

alfsb · 2024-12-04T17:20:23Z

The same list as above, with diff links, to more easily see what changes are to be (or already has been) applied. The worst I found by an superficial inspection is language/predefined/interfaces.xml, in various languages, that erases an entire page on language/.

es/language/predefined/interfaces.xml diff color
es/reference/cubrid/cubridmysql/cubrid-real-escape-string.xml diff color
es/reference/eio/functions/eio-chmod.xml diff color
es/reference/eio/functions/eio-poll.xml diff color
es/reference/ev/ev/depth.xml diff color
es/reference/mongodb/tutorial.xml diff color

fr/appendices/filters.xml diff color
fr/language/predefined/interfaces.xml diff color
fr/reference/cubrid/cubridmysql/cubrid-real-escape-string.xml diff color
fr/reference/eio/functions/eio-chmod.xml diff color
fr/reference/eio/functions/eio-poll.xml diff color
fr/reference/ev/ev/depth.xml diff color
fr/reference/ev/ev/run.xml diff color
fr/reference/ev/evchild/construct.xml diff color
fr/reference/ev/evloop/run.xml diff color
fr/reference/ev/evstat/attr.xml diff color
fr/reference/ev/evstat/createstopped.xml diff color
fr/reference/ev/evstat/set.xml diff color
fr/reference/ev/evtimer/construct.xml diff color
fr/reference/ev/evtimer/createstopped.xml diff color
fr/reference/ev/evtimer/set.xml diff color
fr/reference/ev/evwatcher/clear.xml diff color
fr/reference/event/eventbufferevent/construct.xml diff color
fr/reference/event/eventbufferevent/setwatermark.xml diff color
fr/reference/event/eventconfig/setmaxdispatchinterval.xml diff color
fr/reference/event/eventdnsbase/parseresolvconf.xml diff color
fr/reference/event/eventdnsbase/setsearchndots.xml diff color
fr/reference/filesystem/functions/stat.xml diff color
fr/reference/imagick/imagickpixel/getcolor.xml diff color
fr/reference/mcrypt/constants.xml diff color
fr/reference/mongodb/architecture.xml diff color
fr/reference/mongodb/bson.xml diff color
fr/reference/mongodb/configure.xml diff color
fr/reference/mongodb/exceptions.xml diff color
fr/reference/mongodb/ini.xml diff color
fr/reference/mongodb/mongodb.xml diff color
fr/reference/mongodb/monitoring.xml diff color
fr/reference/mongodb/security.xml diff color
fr/reference/mongodb/setup.xml diff color
fr/reference/mongodb/tutorial.xml diff color
fr/reference/mongodb/tutorial/apm.xml diff color
fr/reference/mongodb/tutorial/library.xml diff color
fr/reference/oci8/functions/oci-set-prefetch.xml diff color
fr/reference/sockets/functions/socket-read.xml diff color
fr/reference/stream/streamwrapper/url-stat.xml diff color

it/language/predefined/interfaces.xml diff color

ja/appendices/filters.xml diff color
ja/reference/eio/functions/eio-chmod.xml diff color
ja/reference/eio/functions/eio-poll.xml diff color
ja/reference/ev/ev/depth.xml diff color
ja/reference/ev/ev/run.xml diff color
ja/reference/ev/evchild/construct.xml diff color
ja/reference/filesystem/functions/stat.xml diff color
ja/reference/imagick/imagickpixel/getcolor.xml diff color
ja/reference/mcrypt/constants.xml diff color
ja/reference/oci8/functions/oci-set-prefetch.xml diff color
ja/reference/sockets/functions/socket-read.xml diff color
ja/reference/stream/streamwrapper/url-stat.xml diff color

pl/language/predefined/interfaces.xml diff color

ro/reference/mongodb/tutorial.xml diff color

ru/appendices/filters.xml diff color
ru/reference/cubrid/cubridmysql/cubrid-real-escape-string.xml diff color
ru/reference/eio/functions/eio-chmod.xml diff color
ru/reference/eio/functions/eio-poll.xml diff color
ru/reference/ev/ev/depth.xml diff color
ru/reference/ev/ev/run.xml diff color
ru/reference/ev/evchild/construct.xml diff color
ru/reference/ev/evloop/run.xml diff color
ru/reference/ev/evstat/attr.xml diff color
ru/reference/ev/evstat/createstopped.xml diff color
ru/reference/ev/evstat/set.xml diff color
ru/reference/ev/evtimer/construct.xml diff color
ru/reference/ev/evtimer/createstopped.xml diff color
ru/reference/ev/evtimer/set.xml diff color
ru/reference/ev/evwatcher/clear.xml diff color
ru/reference/event/eventbufferevent/construct.xml diff color
ru/reference/event/eventbufferevent/setwatermark.xml diff color
ru/reference/event/eventconfig/setmaxdispatchinterval.xml diff color
ru/reference/event/eventdnsbase/parseresolvconf.xml diff color
ru/reference/event/eventdnsbase/setsearchndots.xml diff color
ru/reference/filesystem/functions/stat.xml diff color
ru/reference/imagick/imagickpixel/getcolor.xml diff color
ru/reference/mcrypt/constants.xml diff color
ru/reference/oci8/functions/oci-set-prefetch.xml diff color
ru/reference/sockets/functions/socket-read.xml diff color
ru/reference/stream/streamwrapper/url-stat.xml diff color

tr/reference/filesystem/functions/stat.xml diff color
tr/reference/imagick/imagickpixel/getcolor.xml diff color
tr/reference/mcrypt/constants.xml diff color
tr/reference/sockets/functions/socket-read.xml diff color
tr/reference/stream/streamwrapper/url-stat.xml diff color

uk/appendices/filters.xml diff color

zh/appendices/filters.xml diff color
zh/language/predefined/interfaces.xml diff color
zh/reference/event/eventconfig/setmaxdispatchinterval.xml diff color
zh/reference/filesystem/functions/stat.xml diff color
zh/reference/mcrypt/constants.xml diff color
zh/reference/oci8/functions/oci-set-prefetch.xml diff color

zh/reference/sockets/functions/socket-read.xml diff color

sy-records · 2024-12-05T02:51:43Z

Thank you, I synchronized it with Chinese.

alfsb · 2024-12-05T10:32:20Z

Addendum: after this PR is merged, the web-doc checkout of doc-base will need a pull.

Girgias · 2024-12-05T12:04:49Z

Addendum: after this PR is merged, the web-doc checkout of doc-base will need a pull.

@jimwins is this a manual thing we need to do?

See php/doc-base#181 for reason

Girgias · 2024-12-05T12:19:30Z

I have synced UK, PL, RO, IT, ES.

TR seems to also be in sync now.

jimwins · 2024-12-05T19:21:34Z

Addendum: after this PR is merged, the web-doc checkout of doc-base will need a pull.
@jimwins is this a manual thing we need to do?

No, it's updated automatically at the same time that the languages are pulled and revcheck is run. That runs every hour.

Girgias · 2024-12-06T18:40:35Z

FR is also now updated.

I think it is fine to merge this now.

alfsb · 2024-12-06T23:30:45Z

It's probably fine to merge. Run a quick test, merging it will bump 45 files to old status, only in 3 repos: doc-ja, doc-ru and doc-zh, all active languages.

alfsb marked this pull request as ready for review November 25, 2024 13:47

alfsb marked this pull request as draft November 25, 2024 14:10

alfsb force-pushed the LOOSE_SKIP_REVCHECK branch from f74fd14 to 8f710c4Compare November 25, 2024 14:29

alfsb closed this Nov 25, 2024

alfsb force-pushed the LOOSE_SKIP_REVCHECK branch from 8f710c4 to e6a8e42Compare November 25, 2024 14:37

Only checks for [skip-revcheck] at start of commit messages
60c6c28

alfsb reopened this Nov 25, 2024

alfsb marked this pull request as ready for review November 25, 2024 15:51

sy-records mentioned this pull request Dec 5, 2024
Sync skip files php/doc-zh#946
Merged

Girgias added a commit to php/doc-uk that referenced this pull request Dec 5, 2024
Sync appendix
8fded1c
See php/doc-base#181 for reason

Girgias added a commit to php/doc-ro that referenced this pull request Dec 5, 2024
Sync Mongo tutorial
2238ae9
See php/doc-base#181 for reason

Girgias added a commit to php/doc-pl that referenced this pull request Dec 5, 2024
Sync predfined interfaces
e54923f
See php/doc-base#181 for reason

Girgias added a commit to php/doc-it that referenced this pull request Dec 5, 2024
Sync predfined interfaces
dd6a1c1
See php/doc-base#181 for reason

Girgias added a commit to php/doc-es that referenced this pull request Dec 5, 2024
Sync predfined interfaces
9f068ed
See php/doc-base#181 for reason

Girgias added a commit to php/doc-es that referenced this pull request Dec 5, 2024
Sync constant to literal tag changes
b7875f1
See php/doc-base#181 for reason

Girgias added a commit to php/doc-es that referenced this pull request Dec 5, 2024
Update MongoDB tutorial revcheck
4300829
See php/doc-base#181 for reason

Girgias mentioned this pull request Dec 5, 2024
Manual infra-estructure #199
Open
47 tasks

Fan2Shrek mentioned this pull request Dec 5, 2024
Various SYNC with EN php/doc-fr#1899
Merged

sy-records approved these changes Dec 6, 2024
View reviewed changes

alfsb mentioned this pull request Feb 23, 2026
Add GitHub Action to track doc-en merged PRs php/doc-pt_br#727
Closed

This was referenced Jul 24, 2026
ci: add per-PR EN-Revision hash check php/doc-ja#413
Closed
ci: add per-PR XML structure check against doc-en php/doc-ja#412
Closed
ci: add workflow to track doc-en changes and open sync issues php/doc-ja#411
Closed

alfsb closed this Aug 3, 2026

alfsb deleted the LOOSE_SKIP_REVCHECK branch August 3, 2026 14:56

Navigation Menu

Uh oh!

Only checks for `[skip-revcheck]` at start of commit messages - #181

Only checks for `[skip-revcheck]` at start of commit messages#181
alfsb wants to merge 1 commit into
php:masterfrom
alfsb:LOOSE_SKIP_REVCHECK

alfsb commented Nov 18, 2024

Uh oh!

alfsb commented Nov 25, 2024

Uh oh!

alfsb commented Nov 25, 2024

Uh oh!

Girgias commented Dec 3, 2024

Uh oh!

alfsb commented Dec 3, 2024

Uh oh!

alfsb commented Dec 4, 2024•
edited by Girgias
Loading

Uh oh!

sy-records commented Dec 5, 2024

Uh oh!

alfsb commented Dec 5, 2024

Uh oh!

Girgias commented Dec 5, 2024

Uh oh!

Girgias commented Dec 5, 2024

Uh oh!

jimwins commented Dec 5, 2024

Uh oh!

Girgias commented Dec 6, 2024

Uh oh!

alfsb commented Dec 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

alfsb commented Nov 18, 2024

Uh oh!

alfsb commented Nov 25, 2024

Uh oh!

alfsb commented Nov 25, 2024

Uh oh!

Girgias commented Dec 3, 2024

Uh oh!

alfsb commented Dec 3, 2024

Uh oh!

alfsb commented Dec 4, 2024• edited by Girgias Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sy-records commented Dec 5, 2024

Uh oh!

alfsb commented Dec 5, 2024

Uh oh!

Girgias commented Dec 5, 2024

Uh oh!

Girgias commented Dec 5, 2024

Uh oh!

jimwins commented Dec 5, 2024

Uh oh!

Girgias commented Dec 6, 2024

Uh oh!

alfsb commented Dec 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alfsb commented Dec 4, 2024•
edited by Girgias
Loading