Uh oh!
There was an error while loading. Please reload this page.
Idempotent build: file-entities.php - #201
Conversation
alfsb
commented
Dec 9, 2024
Conflict resolved. Passes CI, and yet I would like testing of Windows users. I'm trying to make the code as shell free as possible. In particular, I would like to hear if the The Swoole bit may warrant opening an issue, if the docs are still actively developed. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cmb69
commented
Dec 10, 2024
Well, there may be nested comments, which are not allowed in XML.
Gave it a quick try, and detected no issues. |
alfsb
commented
Dec 10, 2024
It's time. Merging. The breakages of |
alfsb
commented
Dec 10, 2024
Thanks for the testing. Building manual on Windows seems to be way more viable now (compared to 2000, at least). php/doc-en#4288 is a thing everyone that builds on Windows should keep a eye, as it is a nasty thing that may caused so much... suffering, for many and many years. Bit me hard, today. |
There are two principal sources of non idempotence in PHP manuals.
scripts/file-entities.php.inandconfigure.phpThis PR rewritesscripts/file-entities.php.ininto idempotentscripts/file-entities.php.scripts/file-entities.php.incomes a long way. It's almost as old as the first solid Docbook XML manual, and got heavily patched in its more than two decades of existence. It had and/or has code for idiosyncrasies of CVS, SVN and git, of Saxon, xsltproc and PhD, of all versions of PHP starting with PHP 4, of almost all operations systems starting with Windows 95... That is a lot of history, and that is a lot of accumulated anachronisms.Tested on all languages with two behavior changes, listed below.
<!ENTITY>output order is changed in manual DTD preambule;The first one is insignificant, but the second one may be a real bug. It almost got me crazy because the commented out entities are rendered on the PHP manual main site, and the code itself hinted of some form of recursive cascading file inclusions.
But tests with PhD xhtml and bigxhtml showed that all differences are basically Swoole related, so there is no any (more?) automatic recursive file loading in
reference/or elsewhere.