Skip to content

add docs for random_int/random_bytes changes in PHP 8.2 - #1813

Merged
Girgias merged 2 commits into
php:masterfrom
realFlowControl:docs/rendom_bytes_int
Sep 26, 2022
Merged

add docs for random_int/random_bytes changes in PHP 8.2#1813
Girgias merged 2 commits into
php:masterfrom
realFlowControl:docs/rendom_bytes_int

Conversation

@realFlowControl

@realFlowControlrealFlowControl commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

Hey there 🖖

this will add docs about the changes in PHP 8.2 to the random_bytes and random_int functions as per php/php-src#9220

Kind regards
Florian

Refs: #1803

TimWolla
TimWolla approved these changes Sep 9, 2022
View reviewed changes

@TimWollaTimWolla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content changes LGTM, I can't comment on the XML format specifics.

@cmb69cmb69 added this to the PHP 8.2 milestone Sep 9, 2022
cmb69
cmb69 approved these changes Sep 9, 2022
View reviewed changes

@cmb69cmb69 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@saundefinedsaundefined mentioned this pull request Sep 12, 2022
Closed
Girgias
Girgias reviewed Sep 26, 2022
View reviewed changes
Comment threadreference/csprng/functions/random-bytes.xml Outdated
Comment threadreference/csprng/functions/random-int.xml Outdated
@Girgias
Girgias merged commit 298f135 into php:masterSep 26, 2022
@realFlowControl
realFlowControl deleted the docs/rendom_bytes_int branch September 26, 2022 09:47
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
@realFlowControlFlorian Engelhardt
@Girgias@tiffany-taylor
Amend documentation for random_int/random_bytes changes in PHP 8.2 (
05aafe8
php#1813)
Co-authored-by: Florian Engelhardt <florian.engelhardt@r-nw.de>
Co-authored-by: George Peter Banyard <girgias@php.net>
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
@realFlowControlFlorian Engelhardt
@Girgias@claudepache
Amend documentation for random_int/random_bytes changes in PHP 8.2 (
7688b7b
php#1813)
Co-authored-by: Florian Engelhardt <florian.engelhardt@r-nw.de>
Co-authored-by: George Peter Banyard <girgias@php.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GirgiasGirgiasGirgias left review comments
@TimWollaTimWollaTimWolla approved these changes
@cmb69cmb69cmb69 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

PHP 8.2

Development

Successfully merging this pull request may close these issues.

4 participants

@realFlowControl@TimWolla@cmb69@Girgias