Skip to content

Documentation for pcntl_waitid - #3518

Merged
Girgias merged 12 commits into
php:masterfrom
vrza:pcntl-waitid
Sep 22, 2024
Merged

Documentation for pcntl_waitid#3518
Girgias merged 12 commits into
php:masterfrom
vrza:pcntl-waitid

Conversation

@vrza

@vrzavrza commented Jul 1, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Related php-src issue

Related php-src PR

Related php-src commit

  • documented new function pcntl_waitid
  • documented related constants
  • added missing documentation for pcntl_get_last_error and pcntl_strerror

@vrzavrza changed the title Added function pcntl_waitidDocumentation for pcntl_waitidJul 1, 2024
@vrzavrza mentioned this pull request Jul 1, 2024
Closed
@devnexen

devnexen commented Jul 7, 2024

Copy link
Copy Markdown
Member

look good/complete overall, the build failures look legit. Anyhow, preferably someone more "senior" will double-check :)

@devnexen
devnexen requested a review from GirgiasJuly 7, 2024 10:24
@vrzavrza mentioned this pull request Jul 20, 2024
Closed
Girgias
Girgias requested changes Aug 25, 2024
View reviewed changes

@GirgiasGirgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through each instance of an issue but every comment should highlight the issues that currently exist.

Comment threadreference/pcntl/functions/pcntl-strerror.xml Outdated
Comment threadreference/pcntl/functions/pcntl-waitid.xml Outdated
Comment threadreference/pcntl/functions/pcntl-waitid.xml
Comment threadreference/pcntl/functions/pcntl-waitid.xml Outdated
Comment threadreference/pcntl/functions/pcntl-waitid.xml Outdated
Comment threadreference/pcntl/functions/pcntl-waitid.xml Outdated
Comment threadreference/pcntl/functions/pcntl-waitid.xml Outdated
Girgias
Girgias requested changes Sep 11, 2024
View reviewed changes

@GirgiasGirgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plenty of review comments still have not been addressed.

@vrzavrza mentioned this pull request Sep 16, 2024
Closed
@vrza
vrza requested a review from GirgiasSeptember 16, 2024 23:19
Girgias
Girgias requested changes Sep 17, 2024
View reviewed changes

@GirgiasGirgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about the wording as I don't know the behaviour but some markup questions

Comment threadreference/pcntl/functions/pcntl-get-last-error.xml Outdated
Comment threadreference/pcntl/functions/pcntl-strerror.xml Outdated
Comment threadreference/pcntl/functions/pcntl-waitid.xml
Comment threadreference/pcntl/functions/pcntl-waitid.xml
Comment threadreference/pcntl/functions/pcntl-waitid.xml Outdated
Girgias
Girgias approved these changes Sep 22, 2024
View reviewed changes

@GirgiasGirgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadreference/pcntl/functions/pcntl-waitid.xml
@Girgias
Girgias merged commit 4ac5624 into php:masterSep 22, 2024
@jdkfxjdkfx mentioned this pull request Nov 20, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GirgiasGirgiasGirgias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrza@devnexen@Girgias