Uh oh!
There was an error while loading. Please reload this page.
PHP 8.4: Document RoundingMode - #4080
Conversation
TimWolla
left a comment
There was a problem hiding this comment.
Overall this LGTM for an initial version.
Uh oh!
There was an error while loading. Please reload this page.
| Round to the nearest integer. | ||
| If the decimal part is <literal>5</literal>, | ||
| round to the integer with the larger absolute value. |
There was a problem hiding this comment.
I assume you've taken all the description from the RFC?
There was a problem hiding this comment.
The bit with the decimal part might need some adjustments either in the documentation for round() or in here, because round() supports rounding to a specified precision instead of integers.
There was a problem hiding this comment.
I have indeed taken them from the RFC, yeah the whole round() semantics is... going to be a PITA.
There was a problem hiding this comment.
I think I will merge as is, feel free to open an issue about the wording to keep track of it
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
* RoundingMode Enumの翻訳を追加 * php/doc-en#4080 での一覧への追加を反映 --------- Co-authored-by: 武田 憲太郎 <takeda@youmind.jp>
Related to #3419 and php/phd#179