Skip to content

Hooks reflection examples output - #4435

Merged
Girgias merged 2 commits into
php:masterfrom
ADmad:hooks-reflection
Feb 22, 2025
Merged

Hooks reflection examples output#4435
Girgias merged 2 commits into
php:masterfrom
ADmad:hooks-reflection

Conversation

@ADmad

@ADmadADmad commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

I have added output for the examples added in #4110. I had to tweak the examples a bit for output readability

@ADmad

ADmad commented Feb 2, 2025

Copy link
Copy Markdown
ContributorAuthor

Merge is not an allowed merge method in this repository.
This branch must not contain merge commits.

Not sure what I can do about that. Someone can also cherry pick my commit or use its patch file.

@Girgias

Copy link
Copy Markdown
Member

Thank you, I will merge the other PR so you can rebase onto of master.


// But this would set the $age to -2 without error.
$rProp->setRawValue($example, -2);
print $example->age;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we mostly use echo in the manual.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These exist in the previous commit, I'll change all print to echo.

@Girgias

Copy link
Copy Markdown
Member

Sorry this took a while, can you rebase on top of master?

@ADmad

Copy link
Copy Markdown
ContributorAuthor

Sorry this took a while, can you rebase on top of master?

Done

@Girgias
Girgias merged commit 49ef347 into php:masterFeb 22, 2025
@Girgias

Copy link
Copy Markdown
Member

Thank you!

@ADmad
ADmad deleted the hooks-reflection branch February 22, 2025 14:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ADmad@Girgias