Skip to content

random: Fix right-open / left-open confusion for Random\IntervalBoundary - #4559

Merged
tiffany-taylor merged 1 commit into
php:masterfrom
TimWolla:random-intervalboundary
Apr 16, 2025
Merged

random: Fix right-open / left-open confusion for Random\IntervalBoundary#4559
tiffany-taylor merged 1 commit into
php:masterfrom
TimWolla:random-intervalboundary

Conversation

@TimWolla

@TimWollaTimWolla commented Mar 23, 2025

Copy link
Copy Markdown
Member

This was correct in my initial suggestions (#3419 (comment)), but incorrect in my later suggestions (#3419 (comment)) 😔


see #3419

@TimWolla
TimWolla requested a review from GirgiasMarch 23, 2025 15:54
@tiffany-taylor
tiffany-taylor merged commit 594f83c into php:masterApr 16, 2025
@tiffany-taylor

Copy link
Copy Markdown
Member

I should have commented before merging. Meant to say LGTM prior to merging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TimWolla@tiffany-taylor