Uh oh!
There was an error while loading. Please reload this page.
Remove 11 unused entities still referenced by translations - #5628
Merged
alfsb merged 8 commits intoAug 20, 2026
Conversation
sy-records
approved these changes
Jun 19, 2026
lacatoireforce-pushed
the
cleanup/translation-referenced-entities
branch
from
June 23, 2026 14:11
58129ba to
1571305Compare
Record them as tombstones in entities/entities-remove.ent (translate="remove") so revcheck gives translations a heads up, instead of a plain deletion.
lacatoireforce-pushed
the
cleanup/translation-referenced-entities
branch
from
July 6, 2026 11:18
1571305 to
8ee3aa0Comparekamil-tekiela
commented
Jul 24, 2026
Member
Is this PR still needed? |
alfsb
commented
Jul 24, 2026
Member
I think it is still good, at least the content changes of language-snippets.ent and entities.remove.ent. I have not tested it, but in principle it shrinks language-snippets.ent, without breaking translations, so manual splitting would be easier in the end. |
Master merged php#5634 (entities/ mechanism) and php#5742 (DTD subsystem minimization) in the meantime: - docbookcs.xml: keep master side, extensions.ent and language-defs.ent are gone; - language-snippets.ent: take master's reflowed file and drop the 11 unused entities again; - entities/entities-remove.ent: superseded by entities/entities.remove.ent, the 11 tombstones are recorded there; - entities/entities.ent: leftover of the php#5634 example, already covered by entities/entities.extcat.ent.
alfsb
commented
Aug 17, 2026
Member
Tested today, all languages build. Plan to merge this week. |
kamil-tekiela
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the unused-entities cleanup, kept separate because these 11 entities are still referenced by some translations (it/ro/uk/tr/ru/es, depending on the entity).
They are unused in doc-en (directly or transitively), so removing them changes no rendered EN output. Instead of a plain deletion, they are now recorded as tombstones in
entities/entities-remove.ent(translate="remove"), so revcheck gives the translations a heads up to drop them on their side.Stacked on #5634, which introduces the
entities/mechanism. Also waiting for php/doc-base#301 to be merged.