Skip to content

Add translation for OOP visibility, properties and interfaces - #140

Open
lacatoire wants to merge 3 commits into
php:masterfrom
lacatoire:add-oop-visibility-properties-interfaces
Open

Add translation for OOP visibility, properties and interfaces#140
lacatoire wants to merge 3 commits into
php:masterfrom
lacatoire:add-oop-visibility-properties-interfaces

Conversation

@lacatoire

Copy link
Copy Markdown
Member

Add Italian translation for visibility, properties and interfaces documentation

@lacatoire
lacatoireforce-pushed the add-oop-visibility-properties-interfaces branch from f30d37f to ddf5280CompareFebruary 26, 2026 17:06
@lacatoirelacatoire reopened this Jul 15, 2026

@vpintidevvpintidev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a misalignment with the current English source.

interfaces.xml and properties.xml were updated in en after this PR's declared revisions by commit dff848b1 (#5728, "Fix grammar in oop5"). For interfaces.xml it's an English-only grammar fix that doesn't affect the translation. For properties.xml the commit also converts a <para> to <simpara> and fixes a method-name typo in an example (setNumberofSidessetNumberOfSides, see line comment). Those should be applied and the EN-Revision bumped to dff848b1:

  • interfaces.xml: 565bd8b6dff848b1
  • properties.xml: 801e7a15dff848b1

visibility.xml is fully aligned.

Comment threadlanguage/oop5/properties.xml Outdated

$triangle = new Shape();
$triangle->setName("triangle");
$triangle->setNumberofSides(3);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incoerenza nel nome del metodo: qui è chiamato setNumberofSides, ma alla riga 144 è definito setNumberOfSides (con la O maiuscola). Da uniformare. Nell'inglese è stato corretto dal commit #5728.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lacatoire@vpintidev