Skip to content

Rework CLI input and scope handling - #33

Merged
jordikroon merged 15 commits into
php:mainfrom
NickSdot:stack-02-cli-scope
Jul 25, 2026
Merged

Rework CLI input and scope handling#33
jordikroon merged 15 commits into
php:mainfrom
NickSdot:stack-02-cli-scope

Conversation

@NickSdot

@NickSdotNickSdot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Makes diff the default input, detects piped diffs automatically, adds --wide, and separates input planning from execution.

Depends on #29, #30, #31, and #32.
This PR diff will shrink as preceding PRs are merged and this branch is rebased.

As discussed --diff-behaviour is now the default. Piping a diff is still possible and detected automatically -- it no longer requires a --diff flag and diffs can be piped, hence --diff had no more function and was removed. Passing paths works as before. Since diff is not default, full runs are now covered by either docbook-cs . or docbook-cs path/docs-root/. What we discussed as --greedy is now --wider. The table shows how it works.

Input--wideFull File(s)ReferencesMeaning
none❌❌❌diff against branch point
none✅✅✅files and all referenced XML
<path>❌✅❌full file or directory
<path>✅✅✅full file or directory plus referenced XML
git diff | …❌❌❌piped diff scope
git diff | …✅✅✅piped diff files and referenced XML

This was referenced Jul 20, 2026
Merged
Merged
Closed
Merged
@NickSdot
NickSdotforce-pushed the stack-02-cli-scope branch from ce2dbce to 0563975CompareJuly 21, 2026 00:15
This was referenced Jul 21, 2026
Merged
Merged
Merged
@NickSdot
NickSdotforce-pushed the stack-02-cli-scope branch 2 times, most recently from 4d87315 to 7c3fc93CompareJuly 21, 2026 08:44
@NickSdotNickSdot mentioned this pull request Jul 21, 2026
Merged
@jordikroonjordikroon mentioned this pull request Jul 21, 2026
Merged
@NickSdot
NickSdotforce-pushed the stack-02-cli-scope branch from 7c3fc93 to c26bc1eCompareJuly 22, 2026 05:40
@NickSdot
NickSdotforce-pushed the stack-02-cli-scope branch from c26bc1e to 78d850bCompareJuly 22, 2026 07:39
@NickSdot
NickSdot marked this pull request as ready for review July 22, 2026 07:39
@NickSdot

NickSdot commented Jul 22, 2026

Copy link
Copy Markdown
ContributorAuthor

Rebased and ready for review.

@NickSdotNickSdot mentioned this pull request Jul 22, 2026
Merged
jordikroon
jordikroon requested changes Jul 22, 2026
View reviewed changes
Comment threadsrc/Application.php Outdated
Comment threadsrc/Application.php Outdated
Comment threadsrc/Application.php
Comment threadphpunit.xml.dist Outdated
Comment threadsrc/Diff/GitDiffProvider.php Outdated
@NickSdot
NickSdot marked this pull request as draft July 24, 2026 16:08
@NickSdot
NickSdot marked this pull request as ready for review July 24, 2026 18:47
jordikroon
jordikroon requested changes Jul 24, 2026
View reviewed changes
Comment threadsrc/Application.php Outdated
Comment threadsrc/Application.php Outdated
Comment threadsrc/Git/GitClient.php Outdated
@NickSdot

NickSdot commented Jul 25, 2026

Copy link
Copy Markdown
ContributorAuthor

Review comments addressed.

@jordikroon
jordikroon merged commit af323b9 into php:mainJul 25, 2026
3 checks passed
jordikroon added a commit to php/doc-en that referenced this pull request Jul 25, 2026
@jordikroon
Drop --diff from docbook-cs as perphp/docbook-cs#33
7804865
NickSdot added a commit to NickSdot/php__docbook-cs that referenced this pull request Jul 25, 2026
@NickSdot
test: removed obsolete todos
1703b41
ref php#33 (comment)
@NickSdotNickSdot mentioned this pull request Jul 25, 2026
Merged
NickSdot added a commit to NickSdot/php__docbook-cs that referenced this pull request Jul 25, 2026
@NickSdot
test: removed obsolete todos
c770254
ref php#33 (comment)
NickSdot added a commit to NickSdot/php__docbook-cs that referenced this pull request Jul 25, 2026
@NickSdot
test: removed obsolete todos
fc3a703
ref php#33 (comment)
This was referenced Jul 25, 2026
Merged
Merged
NickSdot added a commit to NickSdot/php__docbook-cs that referenced this pull request Jul 26, 2026
@NickSdot
test: removed obsolete todos
aa177dd
ref php#33 (comment)
jordikroon pushed a commit that referenced this pull request Jul 26, 2026
@NickSdot
Final test coverage sweep (#42)
865fb5d
* test: drop redundancy to avoid coverage gymnastics
* test: suppressed native warning
* test: added coverage for UpstreamResolver
* test: added early return
* test: increased coverage
* test: increased edge case coverage
* test: added cwd fallback
* test: added fixer mapping coverage
* test: removed obsolete todos
ref #33 (comment)
* test: simplified simpara source matching
* test: covered declaration masking
* test: covered valid indentation styles
* test: covered exception name mismatch
* test: covered report edge cases
* test: covered input all paths
* test: covered diff edge cases
* test: covered scope edge cases
* test: covered noop fix edge cases
* test: covered fixer input edge cases
* test: academics
* test: academics
* test: covered processing failure paths
* test: removed @api; now covered by tests
* review: removed yoda style
@NickSdot
NickSdot deleted the stack-02-cli-scope branch August 24, 2026 08:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordikroonjordikroonjordikroon requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickSdot@jordikroon