make frankenphp directive optional, thanks @francislavoie

[henderkes]

No description provided.

[francislavoie]

I didn't realize a global variable was being used here

https://github.com/dunglas/frankenphp/blob/b6fcab5a95677a111405473f15d7b6da026b58e9/caddy/caddy.go#L38

This can be gotten rid of by having each handler instance call methods on the app instance in Provision to add their worker configs (and that would validate if there's conflicts).

So like:

app, err:=ctx.App("frankenphp")
iferr!=nil {
returnerr
}
app.AddWorkerConfig(...)

It's not right at all that UnmarshalCaddyfile is setting global variables that are later picked up at runtime. That means that if someone uses Caddy's config API to push a new JSON config (Caddyfile adapted to JSON out of band) then it wouldn't work because a different process adapted the Caddyfile config than the one that will actually run it.

[henderkes]

edit : resolved

[dunglas]

Excellent work. Thanks!