Skip to content

Add support enum links - #188

Merged
Girgias merged 5 commits into
php:masterfrom
SakiTakamachi:add_support_enum_links
Feb 6, 2025
Merged

Add support enum links#188
Girgias merged 5 commits into
php:masterfrom
SakiTakamachi:add_support_enum_links

Conversation

@SakiTakamachi

@SakiTakamachiSakiTakamachi commented Jan 29, 2025

Copy link
Copy Markdown
Member

In my local:

スクリーンショット 2025-01-31 17 27 57

Actually, it would be nice to be able to link RoundingMode::HalfAwayFromZero as well, but that might be a good idea to wait for a follow-up.

@SakiTakamachi

Copy link
Copy Markdown
MemberAuthor

@haszi
With this change enumname behaves like classname, are there any concerns?
(I'm not very familiar with the docs)

Comment threadphpdotnet/phd/Package/PHP/XHTML.php Outdated
@TimWolla
TimWolla requested review from Girgias and hasziJanuary 30, 2025 18:33
@TimWollaTimWolla mentioned this pull request Jan 28, 2025
7 tasks
@SakiTakamachi
SakiTakamachiforce-pushed the add_support_enum_links branch 2 times, most recently from 7f5e3a9 to d5d5e3fCompareJanuary 31, 2025 08:20
@SakiTakamachi
SakiTakamachi marked this pull request as ready for review January 31, 2025 08:29

@GirgiasGirgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Girgias
Girgias merged commit 3c00a1a into php:masterFeb 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@SakiTakamachi@TimWolla@Girgias