Skip to content

Remove dead code - #43

Closed
kamil-tekiela wants to merge 3 commits into
php:masterfrom
kamil-tekiela:Remove-unused-variables
Closed

Remove dead code#43
kamil-tekiela wants to merge 3 commits into
php:masterfrom
kamil-tekiela:Remove-unused-variables

Conversation

@kamil-tekiela

Copy link
Copy Markdown
Member

I checked the code visually and I removed code highlighted by my IDE. This is the first step to getting this project into shape.

@TysonAndreTysonAndre left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but I'm not familiar with the code (e.g. from the names of the methods I'd guess they'd be safe to remove)

@kamil-tekiela

Copy link
Copy Markdown
MemberAuthor

@Girgias@salathe Is there any chance to get this PR approved and merged before #52?

Comment threadphpdotnet/phd/Package/PHP/PDF.php
@kamil-tekiela
kamil-tekielaforce-pushed the Remove-unused-variables branch from 499b9db to 642b6e7CompareJuly 30, 2021 20:08
@kamil-tekielakamil-tekiela mentioned this pull request Oct 13, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kamil-tekiela@TysonAndre@Girgias