Uh oh!
There was an error while loading. Please reload this page.
Remove curly brace array offset - #60
Closed
iggyvolz wants to merge 1 commit into
Closed
Conversation
cmb69
commented
Nov 24, 2021
Member
Yeah, the PDF rendered is unused (since 2012 or so). |
kamil-tekiela
commented
Nov 24, 2021
Member
We could merge this PR. There are more instances of this issue as well as numerous other issues. Maybe, the first step should be removing the PDF renderer? |
cmb69
commented
Nov 24, 2021
Member
+1 on removing the PDF renderer |
Closed
haszi
commented
Nov 28, 2025
Contributor
Closing this as there are no more curly brace array offsets in the codebase and the PDF renderer has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curly braces for array access were deprecated in PHP 7.4. It looks like the extension this class uses (https://pecl.php.net/package/haru/1.0.4) isn't maintained and is no longer compatible with PHP - might be safe to remove it?