Fix: Stop invoking useless function

[localheinz]

This pull request

• stops invoking a useless function manual_header()

💁‍♂️ For reference, see php/web-php#584.

[kamil-tekiela]

I am not convinced. Can we not decouple PHD from WEB? Why is one calling functions from the other?

[localheinz]

@kamil-tekiela

I am not convinced. Can we not decouple PHD from WEB? Why is one calling functions from the other?

I agree, if @cmb69 hadn't caught it - this is an entire mess!

[cmb69]

PhD doesn't call that function, but rather emits the function call to the manual pages.

@philip, do you have any concerns about this change; AFAIK, you're no longer using the latest versions of PhD, but I want to make that we're not breaking anything for you.

[philip]

Thank you @cmb69 for remembering and checking in, I truly appreciate it.

We recently stopped importing PHP's MySQL connector documentation into the MySQL documentation so our use case can be ignored; it's probably safe to treat PhD as a php.net specific project.

[cmb69]

Thanks for the confirmation, @philip! And thank you for the PR, @localheinz!

[localheinz]

Thank you, @cmb69, @kamil-tekiela, @philip, and @salathe!