Uh oh!
There was an error while loading. Please reload this page.
Zend guard recursion protection - #11812
Conversation
dstogov
left a comment
There was a problem hiding this comment.
I think this approach should work.
@iluuu1994 could you please also check the patch.
iluuu1994
left a comment
There was a problem hiding this comment.
I see a tiny slowdown in Symfony Demo of <0.01%. I'm not sure if that's enough to get to the bottom of the direct cause.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bukka
commented
Aug 1, 2023
In terms of the benchmark, it might be a bit tricky to measure because current master is buggy in this behaviour and there is a regression (e.g. you can no longer do var_export in __debugInfo - not a huge deal but still regression as you could do that in 8.2). So you would need to revert all previous commits done by Tyson and measure against that instead. This is a regression fix with addition of that JSON improvemets. |
530e122 to
82b328fCompare82b328f to
fc718a8Compare
This PR introduces a new way of recursion protection in JSON, var_dump and friends. This is alternative solution for what was done in #10020 and specifically implements the solution suggested by Dmitry in #10020 (comment) . More info can be find in that PR so I will not repeat it all here. As mentioned there, it fixes issue in master for __debugInfo and also improves perf for jsonSerializable in some cases.