Skip to content

random: Add PHPAPI to all php_random_algo definitions - #14088

Merged
TimWolla merged 1 commit into
php:masterfrom
TimWolla:random-algo-phpapi
Apr 30, 2024
Merged

random: Add PHPAPI to all php_random_algo definitions#14088
TimWolla merged 1 commit into
php:masterfrom
TimWolla:random-algo-phpapi

Conversation

@TimWolla

Copy link
Copy Markdown
Member

The php_random.h header already defines them as PHPAPI and they actually are part of the public API.


see #14054 (comment)

The php_random.h header already defines them as `PHPAPI` and they actually are
part of the public API.
Co-authored-by: Arnaud Le Blanc <arnaud.lb@gmail.com>

@arnaud-lbarnaud-lb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TimWolla
TimWolla merged commit d5cc7e9 into php:masterApr 30, 2024
@TimWolla
TimWolla deleted the random-algo-phpapi branch April 30, 2024 20:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TimWolla@arnaud-lb