Uh oh!
There was an error while loading. Please reload this page.
Add zend_get_attribute_object() - #14161
Merged
Merged
Conversation
This makes the implementation for `ReflectionAttribute::newInstance()` reusable.
…ance() This test ensures that the `filename` parameter for the fake stack frame is functional. Without it, the stack trace would show `[internal function]` for frame `#0`.
Girgias
reviewed
May 7, 2024
Uh oh!
There was an error while loading. Please reload this page.
Girgias
approved these changes
May 13, 2024
Girgias
left a comment
Member
There was a problem hiding this comment.
You can add an entry in UPGRADING.INTERNALS if you want, but I don't think we generally publicize new APIs in it 🤔
TimWolla
commented
May 14, 2024
MemberAuthor
Doesn't look like it and I'm not starting. Thanks for the review, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the implementation for
ReflectionAttribute::newInstance()reusable.This is related to #11293 where it will come in handy to reliably extract the parameters of the
#[\Deprecated]attribute when named arguments are used.Should the addition of
zend_get_attribute_object()be mentioned in UPGRADING.INTERNALS?