Uh oh!
There was an error while loading. Please reload this page.
Use zend_call_known_function() to call #[\SensitiveParameter]’s constructor - #14254
Merged
Merged
Conversation
…onstructor `zend_call_method_with_1_params()` causes needless overhead, due to the capability of looking up the function by name. It’s also very rarely used (only in ext/spl). `zend_call_known_function()` is the standard methodology to call a known function and going through `Z_OBJCE_P()` avoids the repeated hardcoding of the CE name.
iluuu1994
approved these changes
May 16, 2024
iluuu1994
left a comment
Member
There was a problem hiding this comment.
I think no lookup by name happens, because you're passing fn_proxy with an already set value. Even so, zend_call_known_function avoids one useless level of indirection.
TimWolla
commented
May 16, 2024
MemberAuthor
Correct, but that's unnecessary |
This was referenced Jun 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zend_call_method_with_1_params()causes needless overhead, due to the capability of looking up the function by name. It’s also very rarely used (only in ext/spl).zend_call_known_function()is the standard methodology to call a known function and going throughZ_OBJCE_P()avoids the repeated hardcoding of the CE name.