Uh oh!
There was an error while loading. Please reload this page.
Add a unlink check for php_stream_bucket_unlink - #14339
Closed
jvoisin wants to merge 1 commit into
Closed
Conversation
bukka
reviewed
Jun 2, 2024
Uh oh!
There was an error while loading. Please reload this page.
jvoisinforce-pushed
the
bucket_protect_unlink
branch
2 times, most recently
from
June 6, 2024 15:37
22a31bd to
15f4deeComparejvoisin
commented
Jun 7, 2024
ContributorAuthor
Seems like the Windows failure is unrelated. |
This is in the same spirit as #13943: low-hanging, not in a hot-path, trivial, removing a limited-linear-write → arbitrary-write primitive, … moreover, given how many filters are available, having some low-hanging hardening there shouldn't hurt. cc @arnaud-lb
jvoisinforce-pushed
the
bucket_protect_unlink
branch
from
November 4, 2024 07:43
15f4dee to
492ebb5Comparejvoisin
commented
Nov 4, 2024
ContributorAuthor
@bukka friendly ping :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in the same spirit as #13943: low-hanging, not in a hot-path, trivial, removing a limited-linear-write → arbitrary-write primitive, … moreover, given how many filters are available, having some low-hanging hardening there shouldn't hurt.
cc @arnaud-lb