Uh oh!
There was an error while loading. Please reload this page.
ext/pcre: update Config to match upstream - #14509
Merged
Merged
Conversation
In phpGH-14498, we updated pcre2lib to v10.44. However, it missed syncing the config, that changes upstream `MAX_NAME_SIZE` from 32 to 128. Ref: [1](PCRE2Project/pcre2@ced3b0f#diff-91c5b46dc84a94604a4e4d0caed9bf85590a2eddbb12d2e8dc80badf324a9dfb), [2](PCRE2Project/pcre2@6c670c7)
Ayesh
commented
Jun 8, 2024
MemberAuthor
devnexen
commented
Jun 8, 2024
Member
devnexen
approved these changes
Jun 8, 2024
ndossche
approved these changes
Jun 8, 2024
ndossche
left a comment
Member
There was a problem hiding this comment.
No worries, thanks for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GH-14498, we updated pcre2lib to v10.44. However, it missed syncing the config, that changes upstream
MAX_NAME_SIZEfrom 32 to 128.Ref: 1, 2