Replace @deprecated by #[\Deprecated] for internal functions / class constants

[TimWolla]

This is spun out of and depends on #11293.

[TimWolla]

In the previous PR there were some unresolved threads from @Girgias remaining (regarding version information / messages). And there was a discussion regarding the formatting of the version within the $since. You can find it here: #11293 (comment)

[ndossche]

reason: because entity loading is disabled by default since PHP 8.0.

[TimWolla]

@nielsdos Would libxml_disable_entity_loader(false) reenable it or not?

[ndossche]

Yes but only when also passing LIBXML_NOENT to the parsing options of the XML extensions.

[TimWolla]

I understand that external entities are dangerous, but the deprecation without any alternative sounds wrong.

Anyway: Do you have a specific wording suggestion here? Best to suggest it using GitHub's suggestion feature.

[ndossche]

but the deprecation without any alternative sounds wrong.

You can still use them though, this was necessary to combat shit defaults in libxml2 < v2.9. Since PHP 8.0 we require at least libxml2 v2.9 and so the problem went away.

[ndossche]

Suggested change

	#[\Deprecated(since: '8.0')]
	#[\Deprecated(message: 'External entity loading is disabled by default', since: '8.0')]

[TimWolla]

You can still use them though.

I understand this is not the correct place for this discussion, but does it require the use of this deprecated function to enable them or will this happen automatically when calling libxml_set_external_entity_loader() or so? If the former, then this doesn't really feel like still being able to use them.

Regarding the change: Thanks, applied (with s/External/as external/ to better fit the grammar).

[ndossche]

I understand this is not the correct place for this discussion, but does it require the use of this deprecated function to enable them

No you don't have to use this. You have to pass the LIBXML_NOENT option to an XML parser. libxml_set_external_entity_loader() is orthogonal to this

[Girgias]

I think I've covered all the reasonable alternatives now.

[TimWolla]

I think I've covered all the reasonable alternatives now.

Thanks, all applied and then slightly adjusted for formatting:

• Moved the since parameter first in the stubs, because it is shorter.
• Lowercase use in the message.
• Use consistent phrasing for “use the IntlDateFormatter::format() method instead” 👉 “use IntlDateFormatter::format() instead”

[Girgias]

LGTM from my PoV

[TimWolla]

@Girgias I just did a rebase of the stuff you already reviewed and pushed some more commits to add the missing data / to correct some data. All deprecations have a since value filled in (based on the version where the @deprecated was added first or based on the docs depending on what I could find more easily). I've also added a message where the docs already explained what to do succinctly.

[Girgias]

Okay this is a complete aside, but I just realized that in the documentation, our manual style guide requires use to say "deprecated as of PHP 8.0" instead of "since", not sure if this is something we should match or not, but that's orthogonal to this PR.

[TimWolla]

I think keeping consistency with the property name is valuable here.