Skip to content

8.4 | UPGRADING: various tweaks - #15339

Merged
ndossche merged 2 commits into
php:masterfrom
jrfnl:feature/php-8.4-upgrading-tweaks
Aug 11, 2024
Merged

8.4 | UPGRADING: various tweaks#15339
ndossche merged 2 commits into
php:masterfrom
jrfnl:feature/php-8.4-upgrading-tweaks

Conversation

@jrfnl

Copy link
Copy Markdown
Contributor

8.4 | UPGRADING: various tweaks

[skip ci] 8.4 | UPGRADING: add missing entry for DBA resource to object migration

Ref: #14329

P.S.: looks like #14282 also doesn't have a mention, but that PR doesn't appear to have an impact on userland - maybe a NEWS entry ? /cc @nielsdos@cmb69

@ndosschendossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I don't think the internal resource conversion of com_dotnet needs to be in NEWS because NEWS is normally only for user-facing changes. cc @cmb69 ?

Comment threadUPGRADING Outdated
@cmb69

Copy link
Copy Markdown
Member

I don't think the internal resource conversion of com_dotnet needs to be in NEWS because NEWS is normally only for user-facing changes.

Agreed.

@jrfnl
jrfnlforce-pushed the feature/php-8.4-upgrading-tweaks branch from 22cb10c to efc0024CompareAugust 11, 2024 10:35
Comment threadUPGRADING Outdated
…ct migration
Ref: 14329
P.S.: looks like 14282 also doesn't have a mention, but that PR doesn't appear to have an impact on userland - maybe a NEWS entry ?
@jrfnl
jrfnlforce-pushed the feature/php-8.4-upgrading-tweaks branch from efc0024 to 064ad61CompareAugust 11, 2024 10:46
@ndossche
ndossche merged commit cb8df21 into php:masterAug 11, 2024
@ndossche

Copy link
Copy Markdown
Member

Merged, thanks

@jrfnl
jrfnl deleted the feature/php-8.4-upgrading-tweaks branch August 11, 2024 11:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jrfnl@cmb69@ndossche@petk@devnexen