Uh oh!
There was an error while loading. Please reload this page.
Autotools: Fix pdo_firebird shared build - #15371
Merged
Merged
Conversation
Follow-up of phpGH-15230: - Redundant variables removed - Redundant duplicate middle newlines removed - PHP_CXX_COMPILE_STDCXX macro arguments quoted - When extension is built as shared the PHP_ADD_SOURCES works differently, and PHP_ADD_SOURCES_X needs to be used so this can be used: ./configure --with-pdo-firebird=shared
petk
commented
Aug 13, 2024
MemberAuthor
Merging this as it would be a major issue for the package maintainers causing shared extension not being built... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of GH-15230:
Redundant variables removed
Redundant duplicate middle newlines removed
PHP_CXX_COMPILE_STDCXX macro arguments quoted
When extension is built as shared the PHP_ADD_SOURCES works differently, and PHP_ADD_SOURCES_X needs to be used so this can be used:
./configure --with-pdo-firebird=shared