Skip to content

ext/standard: Add get_declared_enums function - #15443

Open
Ayesh wants to merge 1 commit into
php:masterfrom
Ayesh:get_declared_enums-2
Open

ext/standard: Add get_declared_enums function#15443
Ayesh wants to merge 1 commit into
php:masterfrom
Ayesh:get_declared_enums-2

Conversation

@Ayesh

@AyeshAyesh commented Aug 16, 2024•
edited by TimWolla
Loading

Copy link
Copy Markdown
Member

Adds a get_declared_enums() function that returns a list of declared Enums. This function is similar to the existing get_declared_(classes|interfaces|traits) functions.

RFC: https://wiki.php.net/rfc/get_declared_enums

@AyeshAyesh changed the title ext/standard: Add \get_declared_enums\ functionext/standard: Add get_declared_enums functionAug 16, 2024
@Ayesh
Ayeshforce-pushed the get_declared_enums-2 branch from cea03f6 to f702eafCompareAugust 16, 2024 15:02
iluuu1994
iluuu1994 reviewed Aug 16, 2024
View reviewed changes
Comment threadZend/zend_builtin_functions.c Outdated
@Ayesh
Ayeshforce-pushed the get_declared_enums-2 branch from f702eaf to 45b80b8CompareAugust 16, 2024 15:56
claudepache
claudepache reviewed Aug 16, 2024
View reviewed changes
Comment threadext/standard/tests/class_object/get_declared_enums_basic.phpt Outdated
@Ayesh
Ayeshforce-pushed the get_declared_enums-2 branch 2 times, most recently from 9c8f154 to 18d4150CompareAugust 16, 2024 16:43
jrfnl
jrfnl reviewed Aug 17, 2024
View reviewed changes
Comment threadext/standard/tests/class_object/get_declared_enums_basic.phpt Outdated
jrfnl
jrfnl reviewed Aug 17, 2024
View reviewed changes
Comment threadext/standard/tests/class_object/get_declared_enums_basic.phpt Outdated
@Ayesh
Ayeshforce-pushed the get_declared_enums-2 branch from 18d4150 to 7c38bc2CompareAugust 17, 2024 04:12
@cmb69cmb69 added the RFC label Aug 18, 2024
@Ayesh
Ayeshforce-pushed the get_declared_enums-2 branch from 7c38bc2 to 7192914CompareAugust 21, 2024 17:58
dstogov
dstogov reviewed Aug 26, 2024
View reviewed changes

@dstogovdstogov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems.
Not sure if somebody need this, but implementation is really small.

@iluuu1994 please make a final decision.

@Ayesh

Ayesh commented Aug 26, 2024

Copy link
Copy Markdown
MemberAuthor

Thank you so much @dstogov for the review.
@jrfnl started a draft RFC (https://wiki.php.net/rfc/get_declared_enums) about changing class_exists() and get_declared_classes() to not count Enums as classes. This PR covers the first part of adding a get_declared_enums function (which is not a breaking change).

If the RMs / @iluuu1994 would like to have this on PHP 8.4, that'll be super awesome!

@jrfnl

jrfnl commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

@dstogov FYI: Based on a preliminary discussion about this on the internals mailing list, this will need an RFC. I've prepared one in draft and we (@Ayesh and me) intend to open the formal discussion period for the RFC some time this week (probably once the discussion around default expressions has died down a little).

@jrfnl

jrfnl commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

@Ayesh snap! What a timing ;-)

@Ayesh
Ayeshforce-pushed the get_declared_enums-2 branch from 7192914 to 2b9ffa9CompareSeptember 25, 2024 10:19
@cmb69

This comment was marked as off-topic.

Sign in to view
@iluuu1994

This comment was marked as off-topic.

Sign in to view
@cmb69

This comment was marked as off-topic.

Sign in to view
@cmb69cmb69 mentioned this pull request Sep 26, 2024
Open
3 tasks
@cmb69

This comment was marked as off-topic.

Sign in to view
@Ayesh@iluuu1994
ext/standard: Add get_declared_enums function
2aa0770
Adds a `get_declared_enums()` function that returns a list of declared Enums.
This function is similar to the existing `get_declared_(classes|interfaces|traits)` functions.
Co-Authored-By: Ilija Tovilo <ilija.tovilo@me.com>
@Ayesh
Ayeshforce-pushed the get_declared_enums-2 branch from 2b9ffa9 to 2aa0770CompareOctober 16, 2024 03:01
@Girgias

Girgias commented Apr 6, 2026

Copy link
Copy Markdown
Member

Is this PR/RFC still being pursued?

@jrfnl

jrfnl commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

@Girgias I do still think it has value, but I haven't got the brain space at this particular moment to push it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluuu1994iluuu1994iluuu1994 left review comments
@dstogovdstogovdstogov left review comments
@kocsismatekocsismateAwaiting requested review from kocsismatekocsismate is a code owner
@bukkabukkaAwaiting requested review from bukkabukka is a code owner
+2 more reviewers
@jrfnljrfnljrfnl left review comments
@claudepacheclaudepacheclaudepache left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ABI breakCategory: EngineCategory: OptimizerExtension: standardRFC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Ayesh@jrfnl@cmb69@iluuu1994@Girgias@dstogov@claudepache