Uh oh!
There was an error while loading. Please reload this page.
PDO_Firebird: Add connection level SESSION_TIMEZONE attribute - #15480
PDO_Firebird: Add connection level SESSION_TIMEZONE attribute#15480sim1984 wants to merge 8 commits into
Conversation
cmb69
left a comment
There was a problem hiding this comment.
Thank you! This looks generally sensible to me.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| if(!PDO_FIREBIRD_TEST_DSN) | ||
| { | ||
| die('Error: PDO_FIREBIRD_TEST_DSN must be set'); | ||
| die('Error: PDO_FIREBIRD_TEST_DSN must be set'); |
There was a problem hiding this comment.
I'd stick with 4 spaces as indentation in PHP files, but I don't think we have any CS in this regard.
sim1984
commented
Aug 20, 2024
I can't make an independent PR to clean up the code when there is an active PR. Now I know where I made a mistake. But it is not clear how to reassign a separate branch for an existing PR. |
cmb69
commented
Aug 20, 2024
Ah, I see. I suggest to just close this PR, and open up a new one. |
This feature allows you to set the session time zone when connecting to the database. An alternative is to set the time zone after the connection is established using the query: