Uh oh!
There was an error while loading. Please reload this page.
pdo_firebird: Cleanup code. - #15510
Conversation
Remove unneeded `#if FB_API_VER >= 25`, `#if FB_API_VER >= 30`, `#ifdef SQL_BOOLEAN`
Support force_null for them.
…4 KB. The new limit is 10 MB, no one in their right mind would transmit a query of such length.
mlocati
commented
Aug 20, 2024
About eed7d2d: what about restoring a dump? In this case, we may have rather big queries, right? |
No. There is no support |
cmb69
left a comment
There was a problem hiding this comment.
While I don't understand the SQL_TEXT to SQL_VARYING conversion that already happens, I trust you on this. Generally, this PR looks good to me.
Note that the Windows CI failure is unrelated (see PR#15518).
sim1984
commented
Aug 21, 2024
This is done for the purpose of unification. For other data types, we also convert them to SQL_TEXT if a string is supplied as a parameter. This code is shorter, and at the same time allows empty strings to be treated as NULL for enumerated data types. |
cmb69
commented
Aug 26, 2024
@SakiTakamachi, if you have no objections, I'll merge this tomorrow. |
SakiTakamachi
commented
Aug 26, 2024
I had been in poor health for a long time. This makes sense to me. |
cmb69
commented
Aug 27, 2024
Get well soon @SakiTakamachi! :) |
Since Firebird PDO now requires fbclient 3.0+ to compile, some conditional compilation directives are no longer needed in the code.