Skip to content

Fix iconv_open basic test - #15611

Merged
petk merged 1 commit into
php:PHP-8.2from
petk:patch-iconv-test
Aug 28, 2024
Merged

Fix iconv_open basic test#15611
petk merged 1 commit into
php:PHP-8.2from
petk:patch-iconv-test

Conversation

@petk

@petkpetk commented Aug 28, 2024

Copy link
Copy Markdown
Member

Transliteration works differently across the iconv implementations and the system. When using GNU libiconv the output in this test is: string(16) "Zlutouck'y kun\n"
(like on Windows). On glibc's built-in iconv output is: string(15) "Zlutoucky kun\n"

Targeting PHP-8.2 to have this resolved also on current maintained branches.

Transliteration works differently across the iconv implementations and
the system. When using GNU libiconv the output in this test is:
string(16) "Zlutouck'y kun\n"
(like on Windows). On glibc's built-in iconv output is:
string(15) "Zlutoucky kun\n"

@devnexendevnexen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@petk
petk merged commit 7878a2c into php:PHP-8.2Aug 28, 2024
@petk
petk deleted the patch-iconv-test branch August 28, 2024 12:29
petk added a commit that referenced this pull request Aug 28, 2024
* PHP-8.2:
Fix iconv_open basic test (#15611)
petk added a commit that referenced this pull request Aug 28, 2024
* PHP-8.3:
Fix iconv_open basic test (#15611)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@petk@devnexen