Uh oh!
There was an error while loading. Please reload this page.
ext/mbstring: Update to Unicode 16 - #15898
Conversation
alexdowad
commented
Sep 15, 2024
Thanks very much! |
youkidearitai
left a comment
There was a problem hiding this comment.
I saw changes of Unicode 16.0, Looks good to me.
Thank you very much.
Updates UCD to Unicode 16.0 (released 2024 Sept). Previously: 0fdffc1, php#7502, php#14680 Unicode 16 adds several new character sets and case folding rules. However, the existing ucgendat script can still parse them. This also adds a couple test cases to make sure the new rules for East Asian Wide characters and case folding work correctly. These tests fail on Unicode 15.1 and older because those verisons do not contain those rules.
Ayesh
commented
Sep 16, 2024
Thank you for approving this @alexdowad@youkidearitai. |
alexdowad
commented
Sep 16, 2024
@youkidearitai Shall I merge? |
youkidearitai
commented
Sep 16, 2024
@alexdowad Yes, please! |
youkidearitai
commented
Sep 17, 2024
@alexdowad Did you find any problems? If nothing, shall I merge instead of you? |
alexdowad
commented
Sep 17, 2024
Very sorry, I just got occupied with other things and didn't complete this task. |
alexdowad
commented
Sep 17, 2024
CI failure for WINDOWS_X64_ZTS is spurious. |
alexdowad
commented
Sep 17, 2024
Just to make very sure everything is OK, I downloaded the UCD files for Unicode 16.0.0 and re-ran |
alexdowad
commented
Sep 17, 2024
This is really odd... when I fetch this comment and merge it into |
Ayesh
commented
Sep 17, 2024
Thank you @alexdowad. You are right, the changes are merely after running the script. We had some issues in the script for Unicode 15.1, but 16.0 had no problems. |
alexdowad
commented
Sep 17, 2024
Thanks very much, @Ayesh... this is now landed on |
Ayesh
commented
Sep 17, 2024
Thank you @youkidearitai@alexdowad 🙏. |
Updates UCD to Unicode 16.0 (released 2024 Sept).
Previously: 0fdffc1, #7502, #14680
Unicode 16 adds several new character sets and case folding rules. However, the existing ucgendat script can still parse them.
This also adds a couple test cases to make sure the new rules for East Asian Wide characters and case folding work correctly. These tests fail on Unicode 15.1 and older because those verisons do not contain those rules.