Skip to content

Testing the ABI break labeler - #15969

Closed
cmb69 wants to merge 1 commit into
php:masterfrom
cmb69:cmb/abi-break-test
Closed

Testing the ABI break labeler#15969
cmb69 wants to merge 1 commit into
php:masterfrom
cmb69:cmb/abi-break-test

Conversation

@cmb69

Copy link
Copy Markdown
Member

No description provided.

@cmb69cmb69 closed this Sep 20, 2024
@cmb69

Copy link
Copy Markdown
MemberAuthor

Okay, seems to work[TM]. If a commit changes a published header, the "ABI break" label will be added. Further commits undoing all changes to published headers will not have the "ABI break" label removed; this needs manual removal. But even after manual removal, further changes to published headers will set the "ABI break" label again.

I should note that the list of published headers in labeler.yml is not automatically generated; thus, any change regarding PHP_INSTALL_HEADERS() needs to be manually updated there.

@cmb69
cmb69 deleted the cmb/abi-break-test branch September 20, 2024 22:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@cmb69