Uh oh!
There was an error while loading. Please reload this page.
Fix GH-15980: Signed integer overflow in main/streams/streams.c - #15989
Closed
cmb69 wants to merge 3 commits into
Closed
Fix GH-15980: Signed integer overflow in main/streams/streams.c#15989cmb69 wants to merge 3 commits into
cmb69 wants to merge 3 commits into
Conversation
We need to avoid signed integer overflows which are undefined behavior. We catch that, and set `offset` to `ZEND_LONG_MAX` (which is also the largest value of `zend_off_t` on all platforms). Of course, after such a seek a stream is no longer readable, but that matches the current behavior for offsets near `ZEND_LONG_MAX`.
Girgias
reviewed
Sep 22, 2024
Comment on lines
+1358
to
+1360
| if (UNEXPECTED(offset > ZEND_LONG_MAX - stream->position)) { | ||
| offset = ZEND_LONG_MAX; | ||
| } else { |
Member
There was a problem hiding this comment.
Long term we probably should warn about those large offsets
MemberAuthor
There was a problem hiding this comment.
Yeah, although it's somewhat hard to determine what is too large. Something like ZEND_LONG_MAX - chunk size may work. (I'm mostly thinking about 32bit systems.)
bukka
approved these changes
Sep 22, 2024
cmb69
commented
Sep 22, 2024
MemberAuthor
The new test case fails on 64bit Linux, so this needs closer investigation; for now I have reverted the commits. |
Closed
For some OS/FS, `fseek()` may fail, so `ftell()` will obviously report the old position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to avoid signed integer overflows which are undefined behavior. We catch that, and set
offsettoZEND_LONG_MAX(which is also the largest value ofzend_off_ton all platforms). Of course, after such a seek a stream is no longer readable, but that matches the current behavior for offsets nearZEND_LONG_MAX.