Uh oh!
There was an error while loading. Please reload this page.
Exclude vm files from the ABI break label - #16083
Conversation
cmb69
commented
Sep 27, 2024
Why do we install these files in the first place? |
@cmb69 No idea. |
petk
commented
Sep 27, 2024
I think mostly due to laziness. In the beginning it was probably easier to write wildcard expression to find all the *.h files inside the Zend and main directory, than to write them separately on multiple places. |
cmb69
left a comment
There was a problem hiding this comment.
That was actually a rhetoric question. :) I suggest to unpublish these files via #16070.
Not sure about this PR. We may leave the labeler do its thing, as a reminder of what we did (namely to publish files which have not supposed to be published).
iluuu1994
commented
Sep 27, 2024
Ok, I'll let you handle this then. It would be nice to fix this for older branches though, for the headers that have already been fixed on master. |
No description provided.