Skip to content

Fix pdoodbc_002.phpt to not try to load PDO_odbc - #16096

Merged
cmb69 merged 1 commit into
php:masterfrom
cmb69:cmb/pdoodbc_002.phpt
Sep 28, 2024
Merged

Fix pdoodbc_002.phpt to not try to load PDO_odbc#16096
cmb69 merged 1 commit into
php:masterfrom
cmb69:cmb/pdoodbc_002.phpt

Conversation

@cmb69

Copy link
Copy Markdown
Member

In the --EXTENSIONS-- section, names of extension are handled case- sensitively.


I was pretty confused when I saw https://github.com/php/php-src/actions/runs/11082846756/job/30796380227?pr=16089#step:6:148; but it's pretty clear what's going: if the extension is already loaded, the test runner still tries to load PDO_odbc what even works with a case-insensitive file system. For case-sensitive file system, there likely would be an error about failing to load the extension.

In the `--EXTENSIONS--` section, names of extension are handled case-
sensitively.

@SakiTakamachiSakiTakamachi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cmb69
cmb69 merged commit d812c96 into php:masterSep 28, 2024
@cmb69
cmb69 deleted the cmb/pdoodbc_002.phpt branch September 28, 2024 13:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cmb69@SakiTakamachi