Uh oh!
There was an error while loading. Please reload this page.
Add test for bug GH-16870 (Overly restrictive gmp_pow overflow checks) - #16898
Open
GaryAllan wants to merge 2 commits into
Open
Add test for bug GH-16870 (Overly restrictive gmp_pow overflow checks)#16898GaryAllan wants to merge 2 commits into
GaryAllan wants to merge 2 commits into
Conversation
Girgias
reviewed
Nov 22, 2024
Girgias
left a comment
Member
There was a problem hiding this comment.
Please add an XFAIL section so that CI is green :)
Uh oh!
There was an error while loading. Please reload this page.
Add XFAIL header for CI Co-authored-by: Gina Peter Banyard <girgias@php.net>
cmb69
commented
Nov 22, 2024
Member
IMO, it's better to replace the test case of #16884 with this one, instead of running XFAIL tests in CI while the bug fix is pending. |
This was referenced Nov 25, 2024
Girgias
commented
Jun 24, 2026
Member
Can you rebase this without the XFAIL as we removed the overlow check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test file for Bug #16870
$ /usr/bin/php -v PHP 8.3.14 (cli) (built: Nov 21 2024 14:44:18) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.14, Copyright (c) Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans $ ./run-tests.php -p /usr/bin/php ./ext/gmp/ | grep 16870 PASS Bug GH-16870 (Overly restrictive gmp_pow overflow checks) [ext/gmp/tests/gh16870.phpt]$ ./sapi/cli/php -v PHP 8.5.0-dev (cli) (built: Nov 22 2024 12:04:57) (NTS) Copyright (c) The PHP Group Zend Engine v4.5.0-dev, Copyright (c) Zend Technologies $ ./run-tests.php -p ./sapi/cli/php ./ext/gmp/ | grep 16870 FAIL Bug GH-16870 (Overly restrictive gmp_pow overflow checks) [ext/gmp/tests/gh16870.phpt] Bug GH-16870 (Overly restrictive gmp_pow overflow checks) [ext/gmp/tests/gh16870.phpt]