Uh oh!
There was an error while loading. Please reload this page.
Remove unused CONST_CS flag - #17071
Open
DanielEScherzer wants to merge 1 commit into
Open
Conversation
DanielEScherzer
commented
Dec 6, 2024
MemberAuthor
Pretty confident that the failure is unrelated: |
cmb69
commented
Dec 18, 2024
Member
Generally fine, but might be better to wait for the next major version of PHP. |
kocsismate
commented
Dec 24, 2024
Member
Yes, this change is an ABI break which 3rd party extension have to account for. Since gen_stub.php was recently got rid of using this flag, there are possibly still quite some usages. In order to avoid unnecessarily nagging maintainers, I'd also vote for delaying the removal until PHP 9.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.