Uh oh!
There was an error while loading. Please reload this page.
gen_stub: ZEND_ACC_NODISCARD is for PHP 8.5+ - #18465
Merged
Merged
Conversation
DanielEScherzer
commented
Apr 29, 2025
MemberAuthor
Cross link #17599 |
DanielEScherzer
requested review from
TimWolla and kocsismate
and removed request for
kocsismateApril 29, 2025 22:57
DanielEScherzerforce-pushed
the
stub-NoDiscard
branch
from
April 30, 2025 01:25
44ad6c0 to
dac1b2eCompareDanielEScherzer
marked this pull request as draft
April 30, 2025 01:27
DanielEScherzerforce-pushed
the
stub-NoDiscard
branch
from
April 30, 2025 01:41
dac1b2e to
9b3b222CompareDanielEScherzerforce-pushed
the
stub-NoDiscard
branch
from
April 30, 2025 01:54
9b3b222 to
a993e63CompareDanielEScherzer
marked this pull request as ready for review
April 30, 2025 03:43
TimWolla
approved these changes
Apr 30, 2025
TimWolla
left a comment
Member
There was a problem hiding this comment.
Didn't try to understand all of the changes, but the changes to the arginfo LGTM. Leaving the final approval to Mate.
kocsismate
approved these changes
May 4, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Máté Kocsis <kocsismate90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.