Add ext/uri skeleton along with uriparser

[kocsismate]

Relates to #14461 and https://wiki.php.net/rfc/url_parsing_api

[TimWolla]

Did not verify whether the uriparser files match the upstream sources.

[TimWolla]

These are not currently exported, but exporting the exception CEs might make sense. I suggest to rename them to avoid conflicts.

The following pattern is used by ext/random:

Suggested change

	zend_class_entry*uri_exception_ce;
	zend_class_entry*invalid_uri_exception_ce;
	zend_class_entry*whatwg_invalid_url_exception_ce;
	zend_class_entry*uri_ce_Uri_UriException;
	zend_class_entry*uri_ce_Uri_InvalidUriException;
	zend_class_entry*uri_ce_Uri_WhatWg_InvalidUrlException;

see

php-src/ext/random/random.c

Lines 58 to 72 in c7db07e

	PHPAPIzend_class_entry*random_ce_Random_Engine;
	PHPAPIzend_class_entry*random_ce_Random_CryptoSafeEngine;
	PHPAPIzend_class_entry*random_ce_Random_Engine_Mt19937;
	PHPAPIzend_class_entry*random_ce_Random_Engine_PcgOneseq128XslRr64;
	PHPAPIzend_class_entry*random_ce_Random_Engine_Xoshiro256StarStar;
	PHPAPIzend_class_entry*random_ce_Random_Engine_Secure;
	PHPAPIzend_class_entry*random_ce_Random_Randomizer;
	PHPAPIzend_class_entry*random_ce_Random_IntervalBoundary;
	PHPAPIzend_class_entry*random_ce_Random_RandomError;
	PHPAPIzend_class_entry*random_ce_Random_BrokenRandomEngineError;
	PHPAPIzend_class_entry*random_ce_Random_RandomException;

[kocsismate]

Let's make renames a bit later when the actual content is also added - at least I can then use the IDE to also rename the references. 🤔

[ndossche]

@TimWolla I just validated that uriparser matches upstream at commit 019af45951c76415bd7d999313faf5c0e53aea0d

[ndossche]

I'll sign off for today so I'll check tomorrow again (after CI is green)

[kocsismate]

Ah, I've just realized that I have to add back the UriConfig.h that was a manually added file IIRC, because the CMake based build script would have to generate it by default.

[TimWolla]

LGTM.

Verified the uriparser sources against uriparser/uriparser@019af45 with the addition of the UriConfig.h.

[ndossche]

One remark, otherwise lgtm

[dstogov]

After the merge, the ability to build PHP in a directory different from the source dir is broken.

$ buildconf --force
$ mkdir -p CGI-RELEASE-64
$ cd CGI-RELEASE-64
$ ../configure ...
$ make clean; make -j8
...
/bin/sh /home/dmitry/php/php-master/CGI-RELEASE-64/libtool --silent --preserve-dup-deps --tag=CC --mode=compile cc -Iext/uri/ -I/home/dmitry/php/php-master/ext/uri/ -I/home/dmitry/php/php-master/CGI-RELEASE-64/main -I/home/dmitry/php/php-master/CGI-RELEASE-64 -I/home/dmitry/php/php-master/main -I/home/dmitry/php/php-master -I/usr/include/valgrind -I/home/dmitry/php/php-master/CGI-RELEASE-64/ext/date/lib -I/home/dmitry/php/php-master/ext/date/lib -I/usr/include/libxml2 -I/usr/include/enchant-2 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/home/dmitry/php/php-master/ext/lexbor -I/home/dmitry/php/php-master/ext/mbstring/libmbfl -I/home/dmitry/php/php-master/CGI-RELEASE-64/ext/mbstring/libmbfl -I/home/dmitry/php/php-master/ext/mbstring/libmbfl/mbfl -I/home/dmitry/php/php-master/CGI-RELEASE-64/ext/mbstring/libmbfl/mbfl -I/usr/include/capstone -I/home/dmitry/php/php-master/CGI-RELEASE-64/TSRM -I/home/dmitry/php/php-master/CGI-RELEASE-64/Zend -I/home/dmitry/php/php-master/Zend -I/home/dmitry/php/php-master/TSRM -D_GNU_SOURCE -fno-common -Wstrict-prototypes -Wformat-truncation -Wlogical-op -Wduplicated-cond -Wno-clobbered -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -g -O2 -ffp-contract=off -fvisibility=hidden -DNDEBUG -Wimplicit-fallthrough=1 -DZEND_SIGNALS -Iext/uri/uriparser/include -DURI_STATIC_BUILD -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -c /home/dmitry/php/php-master/ext/uri/uriparser/src/UriNormalize.c -o ext/uri/uriparser/src/UriNormalize.lo -MMD -MF ext/uri/uriparser/src/UriNormalize.dep -MT ext/uri/uriparser/src/UriNormalize.lo
/home/dmitry/php/php-master/ext/uri/uriparser/src/UriCommon.c:41:10: fatal error: uriparser/UriDefsConfig.h: No such file or directory
41 | #include <uriparser/UriDefsConfig.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Please fix this ASAP.

cc: @iluuu1994@nielsdos

[kocsismate]

@dstogov Arnaud has already created a PR to fix this: #18716 I'm going to merge it now.