Uh oh!
There was an error while loading. Please reload this page.
gen_stub: various simplifications and clean up (5) - #18665
Merged
Conversation
DanielEScherzerforce-pushed
the
stub-simplify-5
branch
2 times, most recently
from
May 29, 2025 21:33
89eb11d to
48ae55aCompareDanielEScherzer
commented
Jul 1, 2025
MemberAuthor
@kocsismate should I rebase this now, or after your review? |
kocsismate
commented
Jul 2, 2025
Member
@DanielEScherzer Feel free to do it now! I have only checked very few commits so far :( |
DanielEScherzerforce-pushed
the
stub-simplify-5
branch
from
July 3, 2025 19:20
48ae55a to
414a476CompareDanielEScherzerforce-pushed
the
stub-simplify-5
branch
from
July 21, 2025 20:38
414a476 to
f0722baCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
In preparation for moving this logic to a dedicated class, add support for a maximum version of PHP in the generation of version-dependent flags. This replaces the manual logic in `FuncInfo::getFunctionEntry()` to split up the flags that are used when PHP 8.4 is not supported.
DanielEScherzerforce-pushed
the
stub-simplify-5
branch
2 times, most recently
from
July 24, 2025 00:15
4d78964 to
5da22ccCompareDanielEScherzer
commented
Jul 24, 2025
MemberAuthor
Fixed the issues |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This new class holds the logic for applying different flags based on the PHP version, and replaces `VariableLike::addFlagForVersionsAbove()` (use `VersionFlags::addForVersionsAbove()`) and `generateVersionDependentFlagCode()` (use `VersionFlags::generateVersionDependentFlagCode()`).
Reduce the number of global functions by moving it to instance method `FileInfo::generateClassEntryCode()`.
Reduce the number of global functions by moving it to static method `FileInfo::getFileDocComments()`. Since it is only used by `FileInfo::parseStubFile()`, also make it private.
Simplifies the implementation of `::toTypeCode()` and `::toTypeMask()` by combining the `switch` blocks.
* `FuncInfo::isFinalMethod()` * `FuncInfo::getModifierNames()` * `FuncInfo::equalsApartFromNameAndRefcount()`
Simplifies the implementation of `::getPredefinedConstantTerm()` and `::getPredefinedConstantEntry()`, which only differ in the name of the tag used.
DanielEScherzerforce-pushed
the
stub-simplify-5
branch
from
July 25, 2025 05:36
5da22cc to
657de9bComparekocsismate
approved these changes
Jul 25, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each commit can be reviewed independently, and should have no functional changes