Fix GH-19044: Protected properties are not scoped according to their prototype

[bwoebi]

This should properly cover all cases, especially also around set hooks which get added later on with protected(set) visibility.

Fixes#19044.

[iluuu1994]

Thanks for having a look at this.

[bwoebi]

@iluuu1994 May you please re-review now? :-)

[iluuu1994]

As mentioned, I'd prefer to be inaccurate here and allow writes to protected(set) siblings (linked through a common read-only parent). I don't think this is particularly important in practice.

[bwoebi]

I'd prefer to be inaccurate here and allow writes to protected(set) siblings

I think we might opt into relaxing this eventually, but I would not allow more than actually needed at least for PHP 8.4. We can always revisit it, but I don't think we should do that now.

[bwoebi]

@iluuu1994 Alright, let's just use prototype for everything.

[iluuu1994]

LGTM, thank you for the perseverance. 🙂

[iluuu1994]

Nit: We have gh19044.phpt and gh19044-1.phpt (along with other gh19044.phpt's), which is a bit confusing.

[bwoebi]

So you'd rather have attached a number to them all? I thought first one without number and the extras get one.

[iluuu1994]

Yes, or bump all the other ones by one so we don't have one with without prefix and one with -1. Usually we'll have:

• gh123.phpt
• gh123-2.phpt

Or:

• gh123-1.phpt
• gh123-2.phpt

I prefer the latter, but either works.