Skip to content

standard: Add CHIPS support for setcookie/setrawcookie - #19054

Closed
xepozz wants to merge 1 commit into
php:masterfrom
xepozz:chips
Closed

standard: Add CHIPS support for setcookie/setrawcookie#19054
xepozz wants to merge 1 commit into
php:masterfrom
xepozz:chips

Conversation

@xepozz

Copy link
Copy Markdown
Contributor

@xepozz
xepozz requested a review from bukka as a code ownerJuly 6, 2025 17:16
@TimWollaTimWolla changed the title feat: CHIPS support for setcookie/setrawcookiestandard: Add CHIPS support for setcookie/setrawcookieJul 6, 2025
Comment threadext/standard/head.c
Z_PARAM_STR(domain)
Z_PARAM_BOOL(secure)
Z_PARAM_BOOL(httponly)
Z_PARAM_BOOL(partitioned)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add new parameters. SameSite is only supported within the $options array as well.

see also: #10317.

@ndossche

ndossche commented Jul 6, 2025

Copy link
Copy Markdown
Member

FWIW, I had a previous go at this in 2023 and it required an RFC: #12652

@xepozz

Copy link
Copy Markdown
ContributorAuthor

Close in favor of #12652

@xepozzxepozz closed this Jul 13, 2025
@xepozz
xepozz deleted the chips branch July 15, 2025 09:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@xepozz@ndossche@TimWolla